[Mac] Enables animations for the infobar....

[Mac] Enables animations for the infobar.  Changes the control flow for infobar opening/closing to match Windows more closely.

Nib file changes:
- Embedded the InfoBarGradientView inside an AnimatableView.
- Rebound [controller view] to the AnimatableView and added an infoBarView_ IBOutlet.
- Bound the AnimatableView's delegate_ to the InfoBarController.

BUG=http://crbug.com/25599
TEST=Infobars should animate in and out, except for during tab switches.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30893

[pink (ping after 24hrs), 2009-11-03 21:15:47]

LGTM

http://codereview.chromium.org/354008/diff/2002/3013
File chrome/browser/cocoa/infobar_container_controller.h (right):

http://codereview.chromium.org/354008/diff/2002/3013#newcode65
Line 65: // |controller| is still on the call stack.
does this cause other controllers to animate their position to fill the space or
anything like that?

http://codereview.chromium.org/354008/diff/2002/3011
File chrome/browser/cocoa/infobar_controller.mm (right):

http://codereview.chromium.org/354008/diff/2002/3011#newcode92
Line 92: return (AnimatableView*)[self view];
static_cast?

[rohitrao (ping after 24h), 2009-11-03 22:50:23]

http://codereview.chromium.org/354008/diff/2002/3013
File chrome/browser/cocoa/infobar_container_controller.h (right):

http://codereview.chromium.org/354008/diff/2002/3013#newcode65
Line 65: // |controller| is still on the call stack.
On 2009/11/03 21:15:47, pink wrote:
> does this cause other controllers to animate their position to fill the space
or
> anything like that?

It'll cause a relayout, so any other infobars will jump to fill the space, not
animate.  In practice, this method is only called in two places:
1) At the end of a close animation, in which case the view's height is already
0, so there is no visible change.
2) During a tab switch, in which case we want to get rid of the view without any
animations, and there is no real danger of views jumping to fill the space
because we're in the process of removing every infobar.

I plan to write up a design doc for this.  The control flow when closing
infobars is really complicated, especially around where the TabContents gets
notified that the infobar is gone vs. where the InfoBarDelegate itself is told
to delete itself.

http://codereview.chromium.org/354008/diff/2002/3011
File chrome/browser/cocoa/infobar_controller.mm (right):

http://codereview.chromium.org/354008/diff/2002/3011#newcode92
Line 92: return (AnimatableView*)[self view];
On 2009/11/03 21:15:47, pink wrote:
> static_cast?

Done.

[pink (ping after 24hrs), 2009-11-04 12:44:11]

For the doc, can you add it to the list of docs we plan to write on
the wiki so we don't forget about it?

On Tue, Nov 3, 2009 at 5:50 PM,  <rohitrao@chromium.org> wrote:
>
> http://codereview.chromium.org/354008/diff/2002/3013
> File chrome/browser/cocoa/infobar_container_controller.h (right):
>
> http://codereview.chromium.org/354008/diff/2002/3013#newcode65
> Line 65: // |controller| is still on the call stack.
> On 2009/11/03 21:15:47, pink wrote:
>>
>> does this cause other controllers to animate their position to fill
>
> the space or
>>
>> anything like that?
>
> It'll cause a relayout, so any other infobars will jump to fill the
> space, not animate. =A0In practice, this method is only called in two
> places:
> 1) At the end of a close animation, in which case the view's height is
> already 0, so there is no visible change.
> 2) During a tab switch, in which case we want to get rid of the view
> without any animations, and there is no real danger of views jumping to
> fill the space because we're in the process of removing every infobar.
>
> I plan to write up a design doc for this. =A0The control flow when closin=
g
> infobars is really complicated, especially around where the TabContents
> gets notified that the infobar is gone vs. where the InfoBarDelegate
> itself is told to delete itself.
>
> http://codereview.chromium.org/354008/diff/2002/3011
> File chrome/browser/cocoa/infobar_controller.mm (right):
>
> http://codereview.chromium.org/354008/diff/2002/3011#newcode92
> Line 92: return (AnimatableView*)[self view];
> On 2009/11/03 21:15:47, pink wrote:
>>
>> static_cast?
>
> Done.
>
> http://codereview.chromium.org/354008
>



--=20
Mike Pinkerton
Mac Weenie
pinkerton@google.com