Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 3533013: net: plumb DnsRRResolver from IOThread to HttpNetworkSession. (Closed)

Created:
10 years, 2 months ago by agl
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

net: plumb DnsRRResolver from IOThread to HttpNetworkSession. This patch gets us most of the way. The next patch finishes plumbing into the SSL client socket pool. BUG=none TEST=none

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -14 lines) Patch
M chrome/browser/io_thread.h View 2 chunks +2 lines, -0 lines 1 comment Download
M chrome/browser/io_thread.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/net/connection_tester.cc View 3 chunks +6 lines, -2 lines 1 comment Download
M chrome/service/net/service_url_request_context.cc View 3 chunks +4 lines, -0 lines 1 comment Download
M net/http/http_cache.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/http/http_cache.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M net/http/http_network_layer.h View 5 chunks +5 lines, -0 lines 0 comments Download
M net/http/http_network_layer.cc View 9 chunks +10 lines, -2 lines 0 comments Download
M net/http/http_network_layer_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 4 chunks +4 lines, -0 lines 0 comments Download
M net/http/http_network_session.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_response_body_drainer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_script_fetcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/client_socket_pool_manager.h View 3 chunks +3 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool_manager.cc View 4 chunks +5 lines, -0 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool.h View 6 chunks +6 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 6 chunks +8 lines, -3 lines 1 comment Download
M net/socket/ssl_client_socket_pool_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_util.h View 3 chunks +3 lines, -0 lines 0 comments Download
M net/url_request/url_request_context.h View 3 chunks +6 lines, -0 lines 0 comments Download
M net/url_request/url_request_context.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_unittest.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
agl
10 years, 2 months ago (2010-10-04 19:00:11 UTC) #1
willchan no longer on Chromium
10 years, 2 months ago (2010-10-05 04:33:08 UTC) #2
LGTM

http://codereview.chromium.org/3533013/diff/1/3
File chrome/browser/io_thread.h (right):

http://codereview.chromium.org/3533013/diff/1/3#newcode29
chrome/browser/io_thread.h:29: class DnsRRResolver;
Nit: I think we generally sort these alphabetically.

http://codereview.chromium.org/3533013/diff/1/6
File chrome/browser/net/connection_tester.cc (right):

http://codereview.chromium.org/3533013/diff/1/6#newcode75
chrome/browser/net/connection_tester.cc:75: delete dnsrr_resolver_;
You should delete in the reverse order of construction.  net::HttpCache may be
holding the last references to
net::HttpNetworkLayer=>net::HttpNetworkSession=>etc, so its destructor may still
try to access dnsrr_resolver_, which would be invalid in your current code.

http://codereview.chromium.org/3533013/diff/1/7
File chrome/service/net/service_url_request_context.cc (right):

http://codereview.chromium.org/3533013/diff/1/7#newcode60
chrome/service/net/service_url_request_context.cc:60: delete dnsrr_resolver_;
ditto

http://codereview.chromium.org/3533013/diff/1/22
File net/socket/ssl_client_socket_pool.cc (right):

http://codereview.chromium.org/3533013/diff/1/22#newcode343
net/socket/ssl_client_socket_pool.cc:343: client_socket_factory_,
host_resolver_, dnsrr_resolver_,
80 columns

Powered by Google App Engine
This is Rietveld 408576698