net: plumb DnsRRResolver from IOThread to HttpNetworkSession.

chrome/browser/net/connection_tester.cc

Index: chrome/browser/net/connection_tester.cc
diff --git a/chrome/browser/net/connection_tester.cc b/chrome/browser/net/connection_tester.cc
index 0ed9f948135d7680eeb46b4585d2acb81644b99f..6d90e4f96c86108a3823df9cb9c65ff4bc25c4b0 100644
--- a/chrome/browser/net/connection_tester.cc
+++ b/chrome/browser/net/connection_tester.cc
@@ -12,6 +12,7 @@
 #include "chrome/browser/importer/firefox_proxy_settings.h"
 #include "chrome/common/chrome_switches.h"
 #include "net/base/cookie_monster.h"
+#include "net/base/dnsrr_resolver.h"
 #include "net/base/host_resolver.h"
 #include "net/base/host_resolver_impl.h"
 #include "net/base/io_buffer.h"
@@ -53,13 +54,15 @@ class ExperimentURLRequestContext : public URLRequestContext {
 
     // The rest of the dependencies are standard, and don't depend on the
     // experiment being run.
+    dnsrr_resolver_ = new net::DnsRRResolver;
     ftp_transaction_factory_ = new net::FtpNetworkLayer(host_resolver_);
     ssl_config_service_ = new net::SSLConfigServiceDefaults;
     http_auth_handler_factory_ = net::HttpAuthHandlerFactory::CreateDefault(
         host_resolver_);
     http_transaction_factory_ = new net::HttpCache(
-        net::HttpNetworkLayer::CreateFactory(host_resolver_, proxy_service_,
-            ssl_config_service_, http_auth_handler_factory_, NULL, NULL),
+        net::HttpNetworkLayer::CreateFactory(host_resolver_, dnsrr_resolver_,
+            proxy_service_, ssl_config_service_, http_auth_handler_factory_,
+            NULL, NULL),
         net::HttpCache::DefaultBackend::InMemory(0));
     // In-memory cookie store.
     cookie_store_ = new net::CookieMonster(NULL, NULL);
@@ -69,6 +72,7 @@ class ExperimentURLRequestContext : public URLRequestContext {
 
  protected:
   virtual ~ExperimentURLRequestContext() {
+    delete dnsrr_resolver_;

[willchan no longer on Chromium, 2010/10/05 04:33:08]

You should delete in the reverse order of construction.  net::HttpCache may be
holding the last references to
net::HttpNetworkLayer=>net::HttpNetworkSession=>etc, so its destructor may still
try to access dnsrr_resolver_, which would be invalid in your current code.

     delete ftp_transaction_factory_;
     delete http_transaction_factory_;
     delete http_auth_handler_factory_;