Issue 353016: Enable NEON support in skia when building for armv7

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 353016: Enable NEON support in skia when building for armv7 (Closed)

Created:
11 years, 1 month ago by piman

Modified:
9 years, 7 months ago

Reviewers:
Stephen White

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Enable NEON support in skia when building for armv7 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30795

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	skia/skia.gyp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Stephen White

On 2009/11/03 04:36:10, Stephen White wrote: > LGTM! Hmm, I forgot to mention: you'll probably ...

11 years, 1 month ago (2009-11-03 05:03:11 UTC) #3

piman

11 years, 1 month ago (2009-11-03 05:04:47 UTC) #4

On Mon, Nov 2, 2009 at 10:03 PM, <senorblanco@chromium.org> wrote:

> On 2009/11/03 04:36:10, Stephen White wrote:
>
>> LGTM!
>>
>
> Hmm, I forgot to mention:  you'll probably want to change
> src/opts/SkBitmapProcState_opts_none.cpp ->
> src/opts/SkBitmapProcState_opts_arm.cpp in the gyp file (conditionally on
> arm7,
> of course), and similarly for SkBlitRow_opts_arm.cpp.

Ah, ok, I'll try that and send another CL (it builds for now, but adding
more opts is good).

>
>
> http://codereview.chromium.org/353016
>

Expand Messages | Collapse Messages