Fix mem leak in sync tests by ensuring that the destruction tasks get to run....

Fix mem leak in sync tests by ensuring that the destruction tasks get to run.

BUG=26493
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30789

[tim (not reviewing), 2009-11-03 00:12:11]

http://codereview.chromium.org/353011/diff/1/2
File chrome/browser/sync/profile_sync_service_unittest.cc (right):

http://codereview.chromium.org/353011/diff/1/2#newcode285
Line 285: MessageLoop::current()->RunAllPending();
I'm just a little confused if this works, because the task in question
(RegistrationTask in extensions_activity_monitor.cc) dereferences a
NotificationRegistrar that I would have imagined was deleted by the above
reset()s... ?

[jam, 2009-11-03 00:16:13]

http://codereview.chromium.org/353011/diff/1/2
File chrome/browser/sync/profile_sync_service_unittest.cc (right):

http://codereview.chromium.org/353011/diff/1/2#newcode285
Line 285: MessageLoop::current()->RunAllPending();
On 2009/11/03 00:12:11, timsteele wrote:
> I'm just a little confused if this works, because the task in question
> (RegistrationTask in extensions_activity_monitor.cc)

That's not the task in question.  That task already ran, that's why there's the
leak.  The task that this pumps is the one that leads to
ExtensionsActivityMonitor's destructor running.

> dereferences a
> NotificationRegistrar that I would have imagined was deleted by the above
> reset()s... ?

[tim (not reviewing), 2009-11-03 01:45:27]

LGTM