Fix mem leak in sync tests by ensuring that the destruction tasks get to run....

chrome/browser/sync/profile_sync_service_unittest.cc

Index: chrome/browser/sync/profile_sync_service_unittest.cc
===================================================================
--- chrome/browser/sync/profile_sync_service_unittest.cc	(revision 30691)
+++ chrome/browser/sync/profile_sync_service_unittest.cc	(working copy)
@@ -8,6 +8,7 @@
 #include "testing/gtest/include/gtest/gtest.h"
 
 #include "base/command_line.h"
+#include "base/message_loop.h"
 #include "base/string_util.h"
 #include "base/string16.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
@@ -279,6 +280,9 @@
     // Kill the service before the profile.
     service_.reset();
     profile_.reset();
+
+    // Ensure that the sync objects destruct to avoid memory leaks.
+    MessageLoop::current()->RunAllPending();

[tim (not reviewing), 2009/11/03 00:12:11]

I'm just a little confused if this works, because the task in question
(RegistrationTask in extensions_activity_monitor.cc) dereferences a
NotificationRegistrar that I would have imagined was deleted by the above
reset()s... ?

[jam, 2009/11/03 00:16:13]

That's not the task in question.  That task already ran, that's why there's the
leak.  The task that this pumps is the one that leads to
ExtensionsActivityMonitor's destructor running.

   }
 
   ModelAssociator* associator() {