Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 353010: Better handling of UNKNOWN versus QUERY in a couple ways.... (Closed)

Created:
11 years, 1 month ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com, Paweł Hajdan Jr., ben+cc_chromium.org
Visibility:
Public.

Description

Better handling of UNKNOWN versus QUERY in a couple ways. First, made it possible to navigate to "invalid" hostnames in a number of additional cases, including when the user types an explicit scheme or when we have a valid TLD and no spaces. The default action for these kinds of inputs is still search, but we'll pull up an accidental search infobar if need be now. Second, made the HistoryURLProvider show a What You Typed match for UNKNOWN inputs when the user explicitly typed "http:" or "https:" at the front, since these have the highest probability of being navigational inputs. BUG=26341 TEST=Type "http://foo bar baz.com" and verify you are given a (non-default) entry in the dropdown to navigate. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30830

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -13 lines) Patch
M chrome/browser/autocomplete/autocomplete.cc View 1 chunk +23 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_unittest.cc View 2 chunks +5 lines, -3 lines 1 comment Download
M chrome/browser/autocomplete/history_url_provider.cc View 3 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 3 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
11 years, 1 month ago (2009-11-02 23:36:19 UTC) #1
brettw
11 years, 1 month ago (2009-11-03 03:30:22 UTC) #2
LGTM

http://codereview.chromium.org/353010/diff/1/5
File chrome/browser/autocomplete/autocomplete_unittest.cc (right):

http://codereview.chromium.org/353010/diff/1/5#newcode221
Line 221: { L"foo+bar", AutocompleteInput::QUERY },
Can you add "foo+bar.com"? It would make it a little more clear how this diffes
from "foo+bar"

Powered by Google App Engine
This is Rietveld 408576698