chrome/browser/autocomplete/autocomplete_unittest.cc - Issue 353010: Better handling of UNKNOWN versus QUERY in a couple ways....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/autocomplete_unittest.cc

Issue 353010: Better handling of UNKNOWN versus QUERY in a couple ways.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autocomplete/autocomplete_unittest.cc

===================================================================

--- chrome/browser/autocomplete/autocomplete_unittest.cc (revision 30723)

+++ chrome/browser/autocomplete/autocomplete_unittest.cc (working copy)

@@ -212,11 +212,13 @@

{ L"foo", AutocompleteInput::UNKNOWN },

{ L"foo.c", AutocompleteInput::UNKNOWN },

{ L"foo.com", AutocompleteInput::URL },

- { L"-.com", AutocompleteInput::QUERY },

+ { L"-.com", AutocompleteInput::UNKNOWN },

{ L"foo/bar", AutocompleteInput::URL },

{ L"foo/bar baz", AutocompleteInput::UNKNOWN },

+ { L"foo bar.com", AutocompleteInput::QUERY },

{ L"http://foo/bar baz", AutocompleteInput::URL },

{ L"foo bar", AutocompleteInput::QUERY },

+ { L"foo+bar", AutocompleteInput::QUERY },

brettw 2009/11/03 03:30:22 Can you add "foo+bar.com"? It would make it a litt

{ L"\"foo:bar\"", AutocompleteInput::QUERY },

{ L"link:foo.com", AutocompleteInput::UNKNOWN },

{ L"www.foo.com:81", AutocompleteInput::URL },

@@ -244,8 +246,8 @@

{ L"http://foo.c", AutocompleteInput::URL },

{ L"http://foo.com", AutocompleteInput::URL },

{ L"http://foo_bar.com", AutocompleteInput::URL },

- { L"http://-.com", AutocompleteInput::QUERY },

- { L"http://_foo_.com", AutocompleteInput::QUERY },

+ { L"http://-.com", AutocompleteInput::UNKNOWN },

+ { L"http://_foo_.com", AutocompleteInput::UNKNOWN },

{ L"http://foo.com:abc", AutocompleteInput::QUERY },

{ L"http://foo.com:123456", AutocompleteInput::QUERY },

{ L"http:user@foo.com", AutocompleteInput::URL },