Issue 353009: Fix autofill popups not closing when there are no suggestions. We have to cal...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 353009: Fix autofill popups not closing when there are no suggestions. We have to cal... (Closed)

Created:
11 years, 1 month ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix autofill popups not closing when there are no suggestions. We have to call through on an empty suggestion array so that the popup is told to close. BUG=http://crbug.com/25559 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30821

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/renderer/render_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

You broke it, you (get the CL to) fix it. You always need to call ...

11 years, 1 month ago (2009-11-02 21:19:27 UTC) #1

OK, LGTM

Expand Messages | Collapse Messages