Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Side by Side Diff: chrome/renderer/render_view.cc

Issue 353009: Fix autofill popups not closing when there are no suggestions. We have to cal... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/render_view.h" 5 #include "chrome/renderer/render_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 1213 matching lines...) Expand 10 before | Expand all | Expand 10 after
1224 void RenderView::AddGURLSearchProvider(const GURL& osd_url, bool autodetected) { 1224 void RenderView::AddGURLSearchProvider(const GURL& osd_url, bool autodetected) {
1225 if (!osd_url.is_empty()) 1225 if (!osd_url.is_empty())
1226 Send(new ViewHostMsg_PageHasOSDD(routing_id_, page_id_, osd_url, 1226 Send(new ViewHostMsg_PageHasOSDD(routing_id_, page_id_, osd_url,
1227 autodetected)); 1227 autodetected));
1228 } 1228 }
1229 1229
1230 void RenderView::OnQueryFormFieldAutofillAck( 1230 void RenderView::OnQueryFormFieldAutofillAck(
1231 int query_id, 1231 int query_id,
1232 const std::vector<string16>& suggestions, 1232 const std::vector<string16>& suggestions,
1233 int default_suggestion_index) { 1233 int default_suggestion_index) {
1234 if (webview() && query_id == autofill_query_id_ && !suggestions.empty()) { 1234 if (webview() && query_id == autofill_query_id_) {
1235 webview()->applyAutofillSuggestions( 1235 webview()->applyAutofillSuggestions(
1236 autofill_query_node_, suggestions, default_suggestion_index); 1236 autofill_query_node_, suggestions, default_suggestion_index);
1237 } 1237 }
1238 autofill_query_node_.reset(); 1238 autofill_query_node_.reset();
1239 } 1239 }
1240 1240
1241 void RenderView::OnPopupNotificationVisibilityChanged(bool visible) { 1241 void RenderView::OnPopupNotificationVisibilityChanged(bool visible) {
1242 popup_notification_visible_ = visible; 1242 popup_notification_visible_ = visible;
1243 } 1243 }
1244 1244
(...skipping 2468 matching lines...) Expand 10 before | Expand all | Expand 10 after
3713 new PluginMsg_SignalModalDialogEvent(host_window_)); 3713 new PluginMsg_SignalModalDialogEvent(host_window_));
3714 3714
3715 message->EnableMessagePumping(); // Runs a nested message loop. 3715 message->EnableMessagePumping(); // Runs a nested message loop.
3716 bool rv = Send(message); 3716 bool rv = Send(message);
3717 3717
3718 PluginChannelHost::Broadcast( 3718 PluginChannelHost::Broadcast(
3719 new PluginMsg_ResetModalDialogEvent(host_window_)); 3719 new PluginMsg_ResetModalDialogEvent(host_window_));
3720 3720
3721 return rv; 3721 return rv;
3722 } 3722 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698