Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 3527004: Revert 61142 - Made logging macros evaluate its stream arguments lazily.... (Closed)

Created:
10 years, 2 months ago by akalin
Modified:
9 years, 7 months ago
Reviewers:
akalin
CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 61142 - Made logging macros evaluate its stream arguments lazily. Also added logging unittests. BUG=57383 TEST=logging_unittest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61127 Review URL: http://codereview.chromium.org/3575008 TBR=akalin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -286 lines) Patch
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/leak_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M base/logging.h View 8 chunks +185 lines, -149 lines 0 comments Download
M base/logging.cc View 1 chunk +2 lines, -3 lines 0 comments Download
D base/logging_unittest.cc View 1 chunk +0 lines, -132 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
akalin
10 years, 2 months ago (2010-10-01 02:58:19 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698