base/logging_unittest.cc - Issue 3527004: Revert 61142 - Made logging macros evaluate its stream arguments lazily....

Side by Side Diff: base/logging_unittest.cc

Issue 3527004: Revert 61142 - Made logging macros evaluate its stream arguments lazily.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
	(Empty)
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 #include "base/basictypes.h"

6 #include "base/logging.h"

7

8 #include "testing/gmock/include/gmock/gmock.h"

9 #include "testing/gtest/include/gtest/gtest.h"

10

11 namespace logging {

12

13 namespace {

14

15 using ::testing::Return;

16

17 // Class to make sure any manipulations we do to the min log level are

18 // contained (i.e., do not affect other unit tests).

19 class MinLogLevelSaver {

20 public:

21 MinLogLevelSaver() : old_min_log_level_(GetMinLogLevel()) {}

22

23 ~MinLogLevelSaver() { SetMinLogLevel(old_min_log_level_); }

24

25 private:

26 int old_min_log_level_;

27

28 DISALLOW_COPY_AND_ASSIGN(MinLogLevelSaver);

29 };

30

31 class LoggingTest : public testing::Test {

32 private:

33 MinLogLevelSaver min_log_level_saver_;

34 };

35

36 class MockLogSource {

37 public:

38 MOCK_METHOD0(Log, const char*());

39 };

40

41 TEST_F(LoggingTest, BasicLogging) {

42 MockLogSource mock_log_source;

43 const int kExpectedDebugOrReleaseCalls = 6;

44 const int kExpectedDebugCalls = 6;

45 const int kExpectedCalls =

46 kExpectedDebugOrReleaseCalls + (DEBUG_MODE ? kExpectedDebugCalls : 0);

47 EXPECT_CALL(mock_log_source, Log()).Times(kExpectedCalls).

48 WillRepeatedly(Return("log message"));

49

50 SetMinLogLevel(LOG_INFO);

51

52 EXPECT_TRUE(LOG_IS_ON(INFO));

53 EXPECT_EQ(DEBUG_MODE != 0, DLOG_IS_ON(INFO));

54 EXPECT_TRUE(VLOG_IS_ON(0));

55

56 LOG(INFO) << mock_log_source.Log();

57 LOG_IF(INFO, true) << mock_log_source.Log();

58 PLOG(INFO) << mock_log_source.Log();

59 PLOG_IF(INFO, true) << mock_log_source.Log();

60 VLOG(0) << mock_log_source.Log();

61 VLOG_IF(0, true) << mock_log_source.Log();

62

63 DLOG(INFO) << mock_log_source.Log();

64 DLOG_IF(INFO, true) << mock_log_source.Log();

65 DPLOG(INFO) << mock_log_source.Log();

66 DPLOG_IF(INFO, true) << mock_log_source.Log();

67 DVLOG(0) << mock_log_source.Log();

68 DVLOG_IF(0, true) << mock_log_source.Log();

69 }

70

71 TEST_F(LoggingTest, LoggingIsLazy) {

72 MockLogSource mock_log_source;

73 EXPECT_CALL(mock_log_source, Log()).Times(0);

74

75 SetMinLogLevel(LOG_WARNING);

76

77 EXPECT_FALSE(LOG_IS_ON(INFO));

78 EXPECT_FALSE(DLOG_IS_ON(INFO));

79 EXPECT_FALSE(VLOG_IS_ON(1));

80

81 LOG(INFO) << mock_log_source.Log();

82 LOG_IF(INFO, false) << mock_log_source.Log();

83 PLOG(INFO) << mock_log_source.Log();

84 PLOG_IF(INFO, false) << mock_log_source.Log();

85 VLOG(1) << mock_log_source.Log();

86 VLOG_IF(1, true) << mock_log_source.Log();

87

88 DLOG(INFO) << mock_log_source.Log();

89 DLOG_IF(INFO, true) << mock_log_source.Log();

90 DPLOG(INFO) << mock_log_source.Log();

91 DPLOG_IF(INFO, true) << mock_log_source.Log();

92 DVLOG(1) << mock_log_source.Log();

93 DVLOG_IF(1, true) << mock_log_source.Log();

94 }

95

96 TEST_F(LoggingTest, ChecksAreNotLazy) {

97 MockLogSource mock_log_source, uncalled_mock_log_source;

98 EXPECT_CALL(mock_log_source, Log()).Times(8).

99 WillRepeatedly(Return("check message"));

100 EXPECT_CALL(uncalled_mock_log_source, Log()).Times(0);

101

102 SetMinLogLevel(LOG_FATAL + 1);

103 EXPECT_FALSE(LOG_IS_ON(FATAL));

104

105 CHECK(mock_log_source.Log()) << uncalled_mock_log_source.Log();

106 PCHECK(!mock_log_source.Log()) << mock_log_source.Log();

107 CHECK_EQ(mock_log_source.Log(), mock_log_source.Log())

108 << uncalled_mock_log_source.Log();

109 CHECK_NE(mock_log_source.Log(), mock_log_source.Log())

110 << mock_log_source.Log();

111 }

112

113 TEST_F(LoggingTest, DchecksAreLazy) {

114 MockLogSource mock_log_source;

115 EXPECT_CALL(mock_log_source, Log()).Times(0);

116

117 #if defined(NDEBUG)

118 logging::g_enable_dcheck = false;

119 #else

120 SetMinLogLevel(LOG_FATAL + 1);

121 EXPECT_FALSE(LOG_IS_ON(FATAL));

122 #endif

123 DCHECK(mock_log_source.Log()) << mock_log_source.Log();

124 DPCHECK(mock_log_source.Log()) << mock_log_source.Log();

125 DCHECK_EQ(0, 0) << mock_log_source.Log();

126 DCHECK_EQ(mock_log_source.Log(), static_cast<const char*>(NULL))

127 << mock_log_source.Log();

128 }

129

130 } // namespace

131

132 } // namespace logging

OLD	NEW

« no previous file with comments | « base/logging.cc ('k') | no next file » | no next file with comments »