Add -Wno-non-virtual-dtor flag on posix targets.

Add -Wno-non-virtual-dtor flag on posix targets.

BUG=45135
TEST=Targets build without error.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62529

[cbentzel, 2010-10-02 01:07:46]

The OSX implementation of gcc seems to have uncovered some more violations, but
Ziad seems to have cleaned up all of the issues that the Linux implementation
warns on.

I did validate that -Wno-non-virtual-dtor was included in the compilation flags
on the trybot.

[jar (doing other things), 2010-10-02 01:25:06]

With two nits below....

LGTM

http://codereview.chromium.org/3527003/diff/3001/4001
File build/common.gypi (right):

http://codereview.chromium.org/3527003/diff/3001/4001#newcode1223
build/common.gypi:1223: # TODO(cbentzel): Enable non virtual destructor warning
on OSX. It's gcc implementation
nit: Please include a bug number with the todo.

http://codereview.chromium.org/3527003/diff/3001/4001#newcode1224
build/common.gypi:1224: # currently warns about more violations than Linux's gcc
implementation.
nit: Probably keep under 80 characters unless you really need to... and in
comments, there no real need.

[cbentzel, 2010-10-04 11:12:05]

http://codereview.chromium.org/3527003/diff/3001/4001
File build/common.gypi (right):

http://codereview.chromium.org/3527003/diff/3001/4001#newcode1223
build/common.gypi:1223: # TODO(cbentzel): Enable non virtual destructor warning
on OSX. It's gcc implementation
On 2010/10/02 01:25:06, jar wrote:
> nit: Please include a bug number with the todo.

I had a bug URL included below, but I'll move it adjacent to the TODO comment.

[jar (doing other things), 2010-10-04 17:26:39]

LGTM