Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: build/common.gypi

Issue 3527003: Add -Wno-non-virtual-dtor flag on posix targets. (Closed)
Patch Set: Remove trailing whitespace Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 9f87a44357d2266babe72d99051ca12e64164f62..c376cb62df675f0cb6e10b62c56381971fa012b8 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -874,6 +874,7 @@
# Make inline functions have hidden visiblity by default.
# Surprisingly, not covered by -fvisibility=hidden.
'-fvisibility-inlines-hidden',
+ '-Wno-non-virtual-dtor',
],
'ldflags': [
'-pthread', '-Wl,-z,noexecstack',
@@ -1237,6 +1238,11 @@
'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
'GCC_VERSION': '4.2',
'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof
+ # TODO(cbentzel): http://crbug.com/45135
+ # Enable non virtual destructor warning on OSX.
+ # It's gcc implementation currently warns about more violations
+ # than Linux's gcc implementation.
+ #'GCC_WARN_NON_VIRTUAL_DESTRUCTOR': 'YES', # -Wno-non-virtual-dtor
# MACOSX_DEPLOYMENT_TARGET maps to -mmacosx-version-min
'MACOSX_DEPLOYMENT_TARGET': '<(mac_deployment_target)',
'PREBINDING': 'NO', # No -Wl,-prebind
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698