Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: chrome/browser/profile_import_process_host.h

Issue 3522004: FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profile_import_process_host.h
diff --git a/chrome/browser/profile_import_process_host.h b/chrome/browser/profile_import_process_host.h
index 8b0d9a356c44f5647d8cc939df49f96381cd4c43..22e0026727be7c549617c75f8f4b3e4386009c33 100644
--- a/chrome/browser/profile_import_process_host.h
+++ b/chrome/browser/profile_import_process_host.h
@@ -35,7 +35,7 @@ class ProfileImportProcessHost : public BrowserChildProcessHost {
class ImportProcessClient :
public base::RefCountedThreadSafe<ImportProcessClient> {
public:
- ImportProcessClient() {}
+ ImportProcessClient();
// These methods are used by the ProfileImportProcessHost to pass messages
// received from the external process back to the ImportProcessClient in
@@ -79,7 +79,7 @@ class ProfileImportProcessHost : public BrowserChildProcessHost {
protected:
friend class base::RefCountedThreadSafe<ImportProcessClient>;
- virtual ~ImportProcessClient() {}
+ virtual ~ImportProcessClient();
private:
friend class ProfileImportProcessHost;
@@ -98,6 +98,7 @@ class ProfileImportProcessHost : public BrowserChildProcessHost {
ProfileImportProcessHost(ResourceDispatcherHost* resource_dispatcher,
ImportProcessClient* import_process_client,
ChromeThread::ID thread_id);
+ virtual ~ProfileImportProcessHost();
// |profile_info|, |items|, and |import_to_bookmark_bar| are all needed by
// the external importer process.
@@ -126,12 +127,10 @@ class ProfileImportProcessHost : public BrowserChildProcessHost {
// Overridden from BrowserChildProcessHost:
virtual void OnProcessCrashed();
- virtual bool CanShutdown() { return true; }
+ virtual bool CanShutdown();
virtual URLRequestContext* GetRequestContext(
uint32 request_id,
- const ViewHostMsg_Resource_Request& request_data) {
- return NULL;
- }
+ const ViewHostMsg_Resource_Request& request_data);
// Receives messages to be passed back to the importer host.
scoped_refptr<ImportProcessClient> import_process_client_;

Powered by Google App Engine
This is Rietveld 408576698