Issue 3519003: crosutils: refine imaging output message (as instructions)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3519003: crosutils: refine imaging output message (as instructions) (Closed)

Created:
10 years, 2 months ago by Hung-Te

Modified:
9 years, 7 months ago

Reviewers:
Kenneth Waters

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

crosutils: refine imaging output message (as instructions) image_to_usb has been made to work inside chroot for quite some time (maybe since http://codereview.chromium.org/1991006), and some special modes may even require it to be executed inside chroot. However the output messages were not fixed, so we should remove the "OUTSIDE CHROOT" alerts. BUG=none TEST=manually: 1. executed build_image and verified that output messages is correct, and the image is really built successfully. 2. executed image_to_usb.sh --from=... --to=/dev/sde and verified output messages is correct, and the USB device is really imaged by the given target Change-Id: I8f4274c5f59a0aa585471469ac285e91c0cead13 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2ffe2be

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -10 lines)			Patch
	M	build_image	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	image_to_usb.sh	View		1 chunk	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm.

Expand Messages | Collapse Messages