Issue 1991006: add the ability to umount automounted devices from within the chroot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1991006: add the ability to umount automounted devices from within the chroot (Closed)

Created:
10 years, 7 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
Nick Sanders, sosa

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git//chromeos

Visibility:
Public.

Description

add the ability to umount automounted devices from within the chroot Talked to kmixter, and we felt that bindmounting the directory in which the host os creates mount points for automounted external devices is the cleanest solution to the inside/outside the chroot problem. By doing this, image_to_usb can be run from inside the chroot without concern. That means that (as far as I understand) the factory install flow can all be done inside the chroot, as well as modding images for test and everything else.

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	src/scripts/enter_chroot.sh	View		2 chunks	+9 lines, -0 lines	0 comments	Download
	M	src/scripts/image_to_usb.sh	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

+nsanders: is this acceptable for factory install's needs as well? On 2010/05/10 18:16:06, sosa wrote: ...

10 years, 7 months ago (2010-05-10 18:24:56 UTC) #3

Nick Sanders

10 years, 7 months ago (2010-05-10 18:48:45 UTC) #4

lgtm
Thanks for fixing this!

On Mon, May 10, 2010 at 11:24 AM, <cmasone@chromium.org> wrote:

> +nsanders: is this acceptable for factory install's needs as well?
>
>
> On 2010/05/10 18:16:06, sosa wrote:
>
>> lgtm! thanks
>>
>
>
>
> http://codereview.chromium.org/1991006/show
>

Expand Messages | Collapse Messages