Issue 3495002: [update_engine] Fix file creation mask to be 0600

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3495002: [update_engine] Fix file creation mask to be 0600 (Closed)

Created:
10 years, 3 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
http://git.chromium.org/git/update_engine.git

Visibility:
Public.

Description

[update_engine] Fix file creation mask to be 0600 In addition to changing the write() call in utils.cc, I also set the umask of the process to be 177 -- meaning that files will be AT MOST -rw------- I do this _after_ we initialize logging, so that we don't create log files with unnecessarily restrictive permissions. BUG=chromium-os:6581 TEST=Unit tests, Change-Id: Id6b805a1524af391755bc1df69ec0f6c382154c2 [update_engine] Ensure that created files have restrictive permissions Change-Id: If93e043465083f7c48619d0e7163dd73f8c46090 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4dc2ada

Patch Set 1 #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -12 lines)			Patch
M	extent_writer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	file_writer.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	main.cc	View	2 chunks	+8 lines, -0 lines	1 comment	Download
M	split_file_writer.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	split_file_writer.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

On 2010/09/22 22:00:32, Chris Masone wrote: > ping?

10 years, 3 months ago (2010-09-23 18:29:18 UTC) #2

adlr

10 years, 3 months ago (2010-09-23 19:16:06 UTC) #3

LGTM

http://codereview.chromium.org/3495002/diff/1/4
File main.cc (right):

http://codereview.chromium.org/3495002/diff/1/4#newcode16
main.cc:16: #include <sys/types.h>
the order of includes is:

corresponding .h, if applicable
c headers in pure alpha order
c++ header in pure alpha order
library headers in pure alpha order
local update_engine headers in pure alpha order

Expand Messages | Collapse Messages