[update_engine] Fix file creation mask to be 0600

main.cc

Index: main.cc
diff --git a/main.cc b/main.cc
index f027033a52172014d4564a6f3d1a2c9ded9682b1..daa5eda97c0949dd7a156bd363f376db0991da2f 100644
--- a/main.cc
+++ b/main.cc
@@ -13,6 +13,8 @@
 #include <gflags/gflags.h>
 #include <glib.h>
 #include <metrics/metrics_library.h>
+#include <sys/types.h>

[adlr, 2010/09/23 19:16:06]

the order of includes is:

corresponding .h, if applicable
c headers in pure alpha order
c++ header in pure alpha order
library headers in pure alpha order
local update_engine headers in pure alpha order

+#include <sys/stat.h>
 
 #include "update_engine/dbus_constants.h"
 #include "update_engine/dbus_service.h"
@@ -105,6 +107,12 @@ int main(int argc, char** argv) {
 
   LOG(INFO) << "Chrome OS Update Engine starting";
 
+  // Ensure that all written files have safe permissions.
+  // This is a mask, so we _block_ execute for the owner, and ALL
+  // permissions for other users.
+  // Done _after_ log file creation.
+  umask(S_IXUSR | S_IRWXG | S_IRWXO);
+
   // Create the single GMainLoop
   GMainLoop* loop = g_main_loop_new(g_main_context_default(), FALSE);