Issue 348070: Added scale hack to work around Windows font metric issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348070: Added scale hack to work around Windows font metric issue. (Closed)

Created:
11 years, 1 month ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Added scale hack to work around Windows font metric issue. BUG=none TESTED=tested sync setup wizard on OS X Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30946

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	chrome/browser/sync/sync_setup_flow.cc	View		1 chunk	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

akalin

On 2009/11/04 00:58:46, akalin wrote: > +nick for review. I will see if Linux is ...

11 years, 1 month ago (2009-11-04 01:01:25 UTC) #2

akalin

On 2009/11/04 01:01:25, akalin wrote: > On 2009/11/04 00:58:46, akalin wrote: > > +nick for ...

11 years, 1 month ago (2009-11-04 05:44:31 UTC) #3

ncarter (slow)

11 years, 1 month ago (2009-11-04 17:24:26 UTC) #4

Right -- we still need to implement HTML dialogs on linux so that we can get
rid of the GTK wizard.

On Tue, Nov 3, 2009 at 9:44 PM, <akalin@chromium.org> wrote:

> On 2009/11/04 01:01:25, akalin wrote:
>
>> On 2009/11/04 00:58:46, akalin wrote:
>> > +nick for review.
>>
>
>  I will see if Linux is affected by this, too.
>>
>
> Linux is not affected by this because it uses a native GTK sync setup
> wizard
> (!).
>
>
> http://codereview.chromium.org/348070
>

Expand Messages | Collapse Messages