Issue 348046: Avoid a CHECK when the modal_loop_pump_messages_event handle comes in as NULL...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348046: Avoid a CHECK when the modal_loop_pump_messages_event handle comes in as NULL... (Closed)

Created:
11 years, 1 month ago by jam

Modified:
9 years, 7 months ago

Reviewers:
amit, eroman

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Avoid a CHECK when the modal_loop_pump_messages_event handle comes in as NULL to the renderer. This happens with some "virus scanners". BUG=25583 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30760

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/renderer/webplugin_delegate_proxy.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ananta

The change LGTM. This would mean that windowless plugins would not dispatch incoming IPC's if ...

11 years, 1 month ago (2009-11-02 21:54:51 UTC) #2

jam

11 years, 1 month ago (2009-11-02 22:24:28 UTC) #3

On Mon, Nov 2, 2009 at 1:54 PM, <ananta@chromium.org> wrote:

> The change LGTM. This would mean that windowless plugins would not dispatch
> incoming IPC's if they enter a modal loop?

Correct.  This would mean that the windowless plugins won't paint when
right-clicking, but the alternative is a crash right now.

>
>
>
> http://codereview.chromium.org/348046
>

Expand Messages | Collapse Messages