Issue 348029: GTK: Use background images for location bar, instead of faking it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348029: GTK: Use background images for location bar, instead of faking it. (Closed)

Created:
11 years, 1 month ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

GTK: Use background images for location bar, instead of faking it. BUG=26258 TEST=Border color of location bar matches the buttons on each side. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30648

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -50 lines)			Patch
	M	chrome/browser/gtk/location_bar_view_gtk.cc	View		2 chunks	+30 lines, -50 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

Screenshots On Fri, Oct 30, 2009 at 4:03 PM, <erg@chromium.org> wrote: > Reviewers: Evan Stade, ...

11 years, 1 month ago (2009-10-30 23:03:58 UTC) #2

Evan Stade

11 years, 1 month ago (2009-10-30 23:24:52 UTC) #4

lg

http://codereview.chromium.org/348029/diff/1/2
File chrome/browser/gtk/location_bar_view_gtk.cc (right):

http://codereview.chromium.org/348029/diff/1/2#newcode506
Line 506: cairo_rectangle(cr, event->area.x, event->area.y, event->area.width,
can use gdk_cairo_rectangle(cr, &event->area)

Expand Messages | Collapse Messages