Issue 348027: Fixed glGetActiveAttrib and glGetUniformLocation to not eagerly check...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348027: Fixed glGetActiveAttrib and glGetUniformLocation to not eagerly check... (Closed)

Created:
11 years, 1 month ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), jam

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixed glGetActiveAttrib and glGetUniformLocation to not eagerly check the incoming index. Callers expect GL errors to be raised for out of range indices. BUG=http://crbug.com/26331 TEST=WebKit/LayoutTests/fast/canvas/webgl/getActiveTest.html (preexisting test; there are two remaining failures which are bugs in the test) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30646

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	webkit/api/src/GraphicsContext3D.cpp	View		2 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages