Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: webkit/api/src/GraphicsContext3D.cpp

Issue 348027: Fixed glGetActiveAttrib and glGetUniformLocation to not eagerly check... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/api/src/GraphicsContext3D.cpp
===================================================================
--- webkit/api/src/GraphicsContext3D.cpp (revision 30543)
+++ webkit/api/src/GraphicsContext3D.cpp (working copy)
@@ -1310,12 +1310,6 @@
{
if (!program)
return false;
- GLint numActiveAttribs = -1;
- glGetProgramiv(EXTRACT(program), GL_ACTIVE_ATTRIBUTES, &numActiveAttribs);
- if (numActiveAttribs < 0)
- return false;
- if (index >= static_cast<GLuint>(numActiveAttribs))
- return false;
GLint maxNameLength = -1;
glGetProgramiv(EXTRACT(program), GL_ACTIVE_ATTRIBUTE_MAX_LENGTH, &maxNameLength);
if (maxNameLength < 0)
@@ -1343,12 +1337,6 @@
{
if (!program)
return false;
- GLint numActiveUniforms = -1;
- glGetProgramiv(EXTRACT(program), GL_ACTIVE_UNIFORMS, &numActiveUniforms);
- if (numActiveUniforms < 0)
- return false;
- if (index >= static_cast<GLuint>(numActiveUniforms))
- return false;
GLint maxNameLength = -1;
glGetProgramiv(EXTRACT(program), GL_ACTIVE_UNIFORM_MAX_LENGTH, &maxNameLength);
if (maxNameLength < 0)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698