Issue 348022: Fix for the crasher with select drop-downs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348022: Fix for the crasher with select drop-downs (Closed)

Created:
11 years, 1 month ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

The fix for bug 24248 did not fully bullet-proof the RenderWidgetHostViewWin for messages recieved after the render view host has been NULLed, causing crashers with select drop-downs. BUG=25290 TEST=Make sure select drop-downs work and don't crash the browser. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30641

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_win.cc	View		4 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eroman

LGTM. (well, the code is a bit of an eyesore, but the logic looks solid ...

11 years, 1 month ago (2009-10-30 20:47:35 UTC) #3

jcampan

11 years, 1 month ago (2009-10-30 20:51:36 UTC) #4

Hopefully we'll get to the bottom of the issue with the DCHECK and
we'll be able to remove these horrible if's from all over the place.

Jay

On Fri, Oct 30, 2009 at 1:47 PM,  <eroman@chromium.org> wrote:
> LGTM.
>
> (well, the code is a bit of an eyesore, but the logic looks solid :)
>
> http://codereview.chromium.org/348022
>

Expand Messages | Collapse Messages