Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 348020: Make --ignore-in-dtor=no the default ThreadSanitizer option (Closed)

Created:
11 years, 1 month ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
Reviewers:
dank
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org
Visibility:
Public.

Description

Make --ignore-in-dtor=no the default ThreadSanitizer option. My local bots (both Linux and Mac) were cycling green with this option all the last week except for one real race (fixed tonight) and two benign reports suppressed recently. This option will help us find more races, especially my beloved ref-counter races. TEST=TSAN bots should remain green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M tools/valgrind/valgrind_test.py View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Timur Iskhodzhanov
11 years, 1 month ago (2009-10-30 15:06:44 UTC) #1
dank
11 years, 1 month ago (2009-10-30 16:53:59 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698