Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/valgrind/valgrind_test.py

Issue 348020: Make --ignore-in-dtor=no the default ThreadSanitizer option (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/valgrind_test.py
===================================================================
--- tools/valgrind/valgrind_test.py (revision 30575)
+++ tools/valgrind/valgrind_test.py (working copy)
@@ -392,6 +392,9 @@
parser.add_option("", "--pure-happens-before", default="yes",
dest="pure_happens_before",
help="Less false reports, more missed races")
+ parser.add_option("", "--ignore-in-dtor", default="no",
+ dest="ignore_in_dtor",
+ help="Ignore data races inside destructors")
parser.add_option("", "--announce-threads", default="yes",
dest="announce_threads",
help="Show the the stack traces of thread creation")
@@ -424,8 +427,11 @@
ret += ["--file-prefix-to-cut=%s/" % self._source_dir]
if self.EvalBoolFlag(self._options.pure_happens_before):
- ret += ["--pure-happens-before=yes"];
+ ret += ["--pure-happens-before=yes"] # "no" is the default value for TSAN
+ if not self.EvalBoolFlag(self._options.ignore_in_dtor):
+ ret += ["--ignore-in-dtor=no"] # "yes" is the default value for TSAN
+
if self.EvalBoolFlag(self._options.announce_threads):
ret += ["--announce-threads"]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698