Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 3471011: Implemented missing instructions in ia32 and x64 disassembler.... (Closed)

Created:
10 years, 3 months ago by Vladislav Kaznacheev
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Implemented missing instructions in ia32 and x64 disassembler. ia32: fld(i), fldpi x64: fld(i), fldpi, cvtsd2si, cvttsd2si Committed: http://code.google.com/p/v8/source/detail?r=5525

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M src/ia32/disasm-ia32.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/disasm-x64.cc View 4 chunks +24 lines, -1 line 2 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vladislav Kaznacheev
Hi Lasse, While debugging r5515 (dec_b support to ia32 and x64 disassembler) I noticed quite ...
10 years, 3 months ago (2010-09-24 11:50:16 UTC) #1
Vladislav Kaznacheev
Hi Lasse, While debugging r5515 (dec_b support to ia32 and x64 disassembler) I noticed quite ...
10 years, 3 months ago (2010-09-24 11:50:16 UTC) #2
Lasse Reichstein
LGTM http://codereview.chromium.org/3471011/diff/1/3 File src/x64/disasm-x64.cc (right): http://codereview.chromium.org/3471011/diff/1/3#newcode1116 src/x64/disasm-x64.cc:1116: current += PrintOperands("cvttss2si", REG_OPER_OP_ORDER, current); Could this function ...
10 years, 3 months ago (2010-09-24 12:19:16 UTC) #3
Vladislav Kaznacheev
10 years, 3 months ago (2010-09-24 12:55:05 UTC) #4
Thanks for the review! Submitting.

http://codereview.chromium.org/3471011/diff/1/3
File src/x64/disasm-x64.cc (right):

http://codereview.chromium.org/3471011/diff/1/3#newcode1116
src/x64/disasm-x64.cc:1116: current += PrintOperands("cvttss2si",
REG_OPER_OP_ORDER, current);
This was the first thing I tried. PrintOperand would call PrintRightOperand
instead of PrintRightXMM operand. Teaching it to do this right would be more
complex, I think.
On 2010/09/24 12:19:16, Lasse Reichstein wrote:
> Could this function be used for cvt[t]sd2si above?
> (If it includes the operand size, it seems it should work the same).

Powered by Google App Engine
This is Rietveld 408576698