[mac] Mark keys with cmd pressed as isSystemKeys.

Mark keys with cmd pressed as isSystemKeys.

BUG=25856
, probably also the Right Fix for 25396
TEST=Go to en.wikipedia.org , make the window very narrow so that there's a horizontal scrollbar. cmd-left/right should go back/forward instead of scrolling horizontally.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30582

[Avi (use Gerrit), 2009-10-30 15:27:12]

When you say "webcore handling a key" you mean inherently? Does this affect a
web page that tries to grab those key events? If not, LG.

[Nico, 2009-10-30 15:48:06]

On Fri, Oct 30, 2009 at 8:27 AM,  <avi@chromium.org> wrote:
> When you say "webcore handling a key" you mean inherently? Does this affect
> a web page that tries to grab those key events? If not, LG.

Webkit still sends the event to javascript first, but if the event
comes back, webkit doesn't use it for scrolling but returns it to the
renderer process (which then returns it to the browser process, which
can then trigger the cmd-left history back shortcut).

Thanks for the review / LG :-)

> http://codereview.chromium.org/347022
>

[James Su, 2009-10-31 00:38:59]

Sorry for late reply, I'm on vacation these days.

isSystemKey flag not only affects RawKeyDown event but also Char event. webkit
will not send a Char event with isSystemKey set to DOM, instead, such Char
events will only be used for triggering accesskeys.

So I think this might be also related to issue 23221.

Regards
James Su

On 2009/10/30 15:48:06, Nico wrote:
> On Fri, Oct 30, 2009 at 8:27 AM,  <mailto:avi@chromium.org> wrote:
> > When you say "webcore handling a key" you mean inherently? Does this affect
> > a web page that tries to grab those key events? If not, LG.
> 
> Webkit still sends the event to javascript first, but if the event
> comes back, webkit doesn't use it for scrolling but returns it to the
> renderer process (which then returns it to the browser process, which
> can then trigger the cmd-left history back shortcut).
> 
> Thanks for the review / LG :-)
> 
> > http://codereview.chromium.org/347022
> >

[jeremy, 2009-11-02 09:00:11]

Sorry if I'm repeating James' comment here, but wouldn't this prevent web apps
from using command as an accesskey - e.g. Yahoo mail overriding command-w on the
mac to close a mail message?