Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1777)

Unified Diff: chrome/browser/views/location_bar_view.h

Issue 347016: Implement page action popups. (Closed)
Patch Set: fixed failing test Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/browser_bubble_win.cc ('k') | chrome/browser/views/location_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/location_bar_view.h
diff --git a/chrome/browser/views/location_bar_view.h b/chrome/browser/views/location_bar_view.h
index 1bae7e79884b57fdd3169fc144ff1bd438f1aa03..8bac24255f6276eeb910989011012f119d886188 100644
--- a/chrome/browser/views/location_bar_view.h
+++ b/chrome/browser/views/location_bar_view.h
@@ -158,6 +158,9 @@ class LocationBarView : public LocationBar,
// Overridden from LocationBarTesting:
virtual int PageActionCount() { return page_action_views_.size(); }
virtual int PageActionVisibleCount();
+ virtual ExtensionAction* GetPageAction(size_t index);
+ virtual ExtensionAction* GetVisiblePageAction(size_t index);
+ virtual void TestPageActionPressed(size_t index);
static const int kVertMargin;
@@ -357,7 +360,8 @@ class LocationBarView : public LocationBar,
int current_tab_id() { return current_tab_id_; }
- // Overridden from view for the mouse hovering.
+ // Overridden from view.
+ virtual void OnMouseMoved(const views::MouseEvent& event);
virtual bool OnMousePressed(const views::MouseEvent& event);
// Overridden from LocationBarImageView.
@@ -371,6 +375,9 @@ class LocationBarView : public LocationBar,
// is the current page URL.
void UpdateVisibility(TabContents* contents, const GURL& url);
+ // Either notify listners or show a popup depending on the page action.
+ void ExecuteAction(int button);
+
private:
// The location bar view that owns us.
LocationBarView* owner_;
« no previous file with comments | « chrome/browser/views/browser_bubble_win.cc ('k') | chrome/browser/views/location_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698