Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/views/browser_bubble_win.cc

Issue 347016: Implement page action popups. (Closed)
Patch Set: fixed failing test Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/location_bar.h ('k') | chrome/browser/views/location_bar_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/browser_bubble_win.cc
diff --git a/chrome/browser/views/browser_bubble_win.cc b/chrome/browser/views/browser_bubble_win.cc
index 3a5bca18105e40835b15405c38c07eb4495f6ea8..4c085eeca0b45be7344f1ecf9f331d2aa9971b3f 100644
--- a/chrome/browser/views/browser_bubble_win.cc
+++ b/chrome/browser/views/browser_bubble_win.cc
@@ -46,8 +46,13 @@ public:
void OnActivate(UINT action, BOOL minimized, HWND window) {
BrowserBubble::Delegate* delegate = bubble_->delegate();
- if (!delegate)
+ if (!delegate) {
+ if (action == WA_INACTIVE && !closed_) {
+ bubble_->DetachFromBrowser();
+ delete bubble_;
+ }
return;
+ }
if (action == WA_INACTIVE && !closed_) {
delegate->BubbleLostFocus(bubble_);
« no previous file with comments | « chrome/browser/location_bar.h ('k') | chrome/browser/views/location_bar_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698