Fixed view example. It was failing because some of view classes requires WidgetGTK in

Fixed view example. It was failing because some of view classes requires WidgetGTK in 
view hierarchy to call methods on it.
 * added ContainerExamlpeBase that defers the creation of such views after WidgetGTK available.

minor fixes
 * replaced unnecessary includes with forward decls.
 * make sure we don't try to set negative hight to viewport.

BUG=None
TEST=build & run view_examples

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30586

[jcampan, 2009-10-28 23:21:05]

Looks like you forgot to include container_example_base.[h,cc]

[oshima, 2009-10-28 23:28:38]

You're right. Uploaded them.

On Wed, Oct 28, 2009 at 4:21 PM, <jcampan@chromium.org> wrote:

> Looks like you forgot to include container_example_base.[h,cc]
>
>
> http://codereview.chromium.org/347010
>

[jcampan, 2009-10-29 00:02:08]

On 2009/10/28 23:28:38, oshima wrote:
> You're right. Uploaded them.
> 
> On Wed, Oct 28, 2009 at 4:21 PM, <mailto:jcampan@chromium.org> wrote:
> 
> > Looks like you forgot to include container_example_base.[h,cc]
> >
> >
> > http://codereview.chromium.org/347010
> >
> 

I am wondering if we need the ContainerExampleBase class. Shouldn't the
ExampleBase have the ContainerExampleBase code in?
I don't see any value in using the ExampleBase class directly.

[oshima, 2009-10-29 00:50:21]

On Wed, Oct 28, 2009 at 5:02 PM, <jcampan@chromium.org> wrote:

> On 2009/10/28 23:28:38, oshima wrote:
>
>> You're right. Uploaded them.
>>
>
>  On Wed, Oct 28, 2009 at 4:21 PM, <mailto:jcampan@chromium.org> wrote:
>>
>
>  > Looks like you forgot to include container_example_base.[h,cc]
>> >
>> >
>> > http://codereview.chromium.org/347010
>> >
>>
>
>
> I am wondering if we need the ContainerExampleBase class. Shouldn't the
> ExampleBase have the ContainerExampleBase code in?
> I don't see any value in using the ExampleBase class directly.
>
>
A few examples do not need container (combobox and button), but yes, you
can implement all of example with container. I don't have strong feeling
about it and
changed it anyway. Let me know.

- oshima


>
> http://codereview.chromium.org/347010
>

[jcampan, 2009-10-29 01:04:38]

http://codereview.chromium.org/347010/diff/1013/1017
File views/examples/example_base.cc (right):

http://codereview.chromium.org/347010/diff/1013/1017#newcode25
Line 25: : example_view_created_(false), example_base_(base) {
Nit: per style guide I believe example_base_ should be on the next line.

http://codereview.chromium.org/347010/diff/1013/1017#newcode32
Line 32: if (is_add && GetWidget() && !example_view_created_) {
I think you can do:
if (is_add && GetWidget() && child == this)

That way you don't need the example_view_created_ member variable.

http://codereview.chromium.org/347010/diff/1013/1017#newcode42
Line 42: examples::ExampleBase* example_base_;
DISALOW_...

[oshima, 2009-10-29 16:17:39]

http://codereview.chromium.org/347010/diff/1013/1017
File views/examples/example_base.cc (right):

http://codereview.chromium.org/347010/diff/1013/1017#newcode25
Line 25: : example_view_created_(false), example_base_(base) {
On 2009/10/29 01:04:38, jcampan wrote:
> Nit: per style guide I believe example_base_ should be on the next line.

Done.

http://codereview.chromium.org/347010/diff/1013/1017#newcode32
Line 32: if (is_add && GetWidget() && !example_view_created_) {
On 2009/10/29 01:04:38, jcampan wrote:
> I think you can do:
> if (is_add && GetWidget() && child == this)
> 
> That way you don't need the example_view_created_ member variable.

This is not correct in a sense that widget may not be available when "this" is
added to the hierarchy. This happens to work in this example because we changed
so that parent tabbed pane always has GetWidget.
 I have slight preference to this as this is more correct, but I'm ok to change
if you feel strongly about it. Please let me know.

http://codereview.chromium.org/347010/diff/1013/1017#newcode42
Line 42: examples::ExampleBase* example_base_;
On 2009/10/29 01:04:38, jcampan wrote:
> DISALOW_...

Done.

[jcampan, 2009-10-30 06:02:48]

LGTM