Remove bold from About label.

Remove bold from About label. 
BUG=25932
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30597

[Mark Mentovai, 2009-10-29 00:46:31]

I thought the Windows behavior change was intentional, because when I "svn
blame"d it, it was obvious that bold had been there for a really long time, but
due to a goof, it wasn't actually having any effect.  I changed the Mac to be
bold too to match.

I'll back out my Mac change, but I need to know if I should take bold off of the
version also.

The GTK+ About box currently uses bold for the title but not for the version.

I assume all three should match.  I can fix GTK+ also.

http://codereview.chromium.org/347009/diff/1001/2001
File chrome/browser/views/about_chrome_view.cc (right):

http://codereview.chromium.org/347009/diff/1001/2001#newcode188
Line 188: ResourceBundle::BaseFont).DeriveFont(0, gfx::Font::BOLD));
Shouldn't we drop this too, to take boldness off of the version number?

[Ben Goodger (Google), 2009-10-29 00:48:53]

LGTM btw. Thanks!

On Wed, Oct 28, 2009 at 3:56 PM, <davemoore@chromium.org> wrote:

> Reviewers: Ben Goodger,
>
> Description:
> Remove bold from About label.
> BUG=25932
> TEST=None
>
> Please review this at http://codereview.chromium.org/347009
>
> Affected files:
>  M chrome/browser/views/about_chrome_view.cc
>
>
> Index: chrome/browser/views/about_chrome_view.cc
> diff --git a/chrome/browser/views/about_chrome_view.cc
> b/chrome/browser/views/about_chrome_view.cc
> index
>
37e544bc8eab53770459c3bfcc7128e0daa011fc..39ba8aa6f2f089b163bd96d2e078714d8642c2fd
> 100755
> --- a/chrome/browser/views/about_chrome_view.cc
> +++ b/chrome/browser/views/about_chrome_view.cc
> @@ -173,7 +173,7 @@ void AboutChromeView::Init() {
>   about_title_label_ = new views::Label(
>       l10n_util::GetString(IDS_PRODUCT_NAME));
>   about_title_label_->SetFont(ResourceBundle::GetSharedInstance().GetFont(
> -      ResourceBundle::BaseFont).DeriveFont(18, gfx::Font::BOLD));
> +      ResourceBundle::BaseFont).DeriveFont(18));
>   about_title_label_->SetColor(SK_ColorBLACK);
>   AddChildView(about_title_label_);
>
>
>
>

[Ben Goodger (Google), 2009-10-29 00:48:54]

If the Mac dev channel is currently bold, then it looks fine as is.

On Windows, it looks craptastic, due to font/font rendering differences.

-Ben

On Wed, Oct 28, 2009 at 5:46 PM, <mark@chromium.org> wrote:

> I thought the Windows behavior change was intentional, because when I "svn
> blame"d it, it was obvious that bold had been there for a really long time,
> but
> due to a goof, it wasn't actually having any effect.  I changed the Mac to
> be
> bold too to match.
>
> I'll back out my Mac change, but I need to know if I should take bold off
> of the
> version also.
>
> The GTK+ About box currently uses bold for the title but not for the
> version.
>
> I assume all three should match.  I can fix GTK+ also.
>
>
> http://codereview.chromium.org/347009/diff/1001/2001
> File chrome/browser/views/about_chrome_view.cc (right):
>
> http://codereview.chromium.org/347009/diff/1001/2001#newcode188
> Line 188: ResourceBundle::BaseFont).DeriveFont(0, gfx::Font::BOLD));
> Shouldn't we drop this too, to take boldness off of the version number?
>
>
> http://codereview.chromium.org/347009
>

[TVL, 2009-10-29 00:51:03]

On Wed, Oct 28, 2009 at 8:48 PM, Ben Goodger (Google) <ben@chromium.org>wrote:

> If the Mac dev channel is currently bold, then it looks fine as is.


Are you looking at 4.0.223.11?  That's not bold on either the product name
or the version number.

TVL


>
> On Windows, it looks craptastic, due to font/font rendering differences.
>
> -Ben
>
>
> On Wed, Oct 28, 2009 at 5:46 PM, <mark@chromium.org> wrote:
>
>> I thought the Windows behavior change was intentional, because when I "svn
>> blame"d it, it was obvious that bold had been there for a really long
>> time, but
>> due to a goof, it wasn't actually having any effect.  I changed the Mac to
>> be
>> bold too to match.
>>
>> I'll back out my Mac change, but I need to know if I should take bold off
>> of the
>> version also.
>>
>> The GTK+ About box currently uses bold for the title but not for the
>> version.
>>
>> I assume all three should match.  I can fix GTK+ also.
>>
>>
>> http://codereview.chromium.org/347009/diff/1001/2001
>> File chrome/browser/views/about_chrome_view.cc (right):
>>
>> http://codereview.chromium.org/347009/diff/1001/2001#newcode188
>> Line 188: ResourceBundle::BaseFont).DeriveFont(0, gfx::Font::BOLD));
>> Shouldn't we drop this too, to take boldness off of the version number?
>>
>>
>> http://codereview.chromium.org/347009
>>
>
>

[Mark Mentovai, 2009-10-29 00:54:22]

It's not.  You're using 223.11, right?  Neither the product name nor
the version is bold in that.

Have you seen it on GTK lately?  The product name is bold but the version i=
sn't.

Ben wrote:
> If the Mac dev channel is currently bold, then it looks fine as is.
> On Windows, it looks craptastic, due to font/font rendering differences.
> -Ben
>
> On Wed, Oct 28, 2009 at 5:46 PM, <mark@chromium.org> wrote:
>>
>> I thought the Windows behavior change was intentional, because when I "s=
vn
>> blame"d it, it was obvious that bold had been there for a really long
>> time, but
>> due to a goof, it wasn't actually having any effect. =A0I changed the Ma=
c to
>> be
>> bold too to match.
>>
>> I'll back out my Mac change, but I need to know if I should take bold of=
f
>> of the
>> version also.
>>
>> The GTK+ About box currently uses bold for the title but not for the
>> version.
>>
>> I assume all three should match. =A0I can fix GTK+ also.
>>
>>
>> http://codereview.chromium.org/347009/diff/1001/2001
>> File chrome/browser/views/about_chrome_view.cc (right):
>>
>> http://codereview.chromium.org/347009/diff/1001/2001#newcode188
>> Line 188: ResourceBundle::BaseFont).DeriveFont(0, gfx::Font::BOLD));
>> Shouldn't we drop this too, to take boldness off of the version number?
>>
>> http://codereview.chromium.org/347009
>
>

[Ben Goodger (Google), 2009-10-29 01:06:05]

Mark points out the version is still bold on Windows. That should be
non-bold too.

-Ben

On Wed, Oct 28, 2009 at 5:53 PM, Mark Mentovai <mark@chromium.org> wrote:

> It's not.  You're using 223.11, right?  Neither the product name nor
> the version is bold in that.
>
> Have you seen it on GTK lately?  The product name is bold but the version
> isn't.
>
> Ben wrote:
> > If the Mac dev channel is currently bold, then it looks fine as is.
> > On Windows, it looks craptastic, due to font/font rendering differences.
> > -Ben
> >
> > On Wed, Oct 28, 2009 at 5:46 PM, <mark@chromium.org> wrote:
> >>
> >> I thought the Windows behavior change was intentional, because when I
> "svn
> >> blame"d it, it was obvious that bold had been there for a really long
> >> time, but
> >> due to a goof, it wasn't actually having any effect.  I changed the Mac
> to
> >> be
> >> bold too to match.
> >>
> >> I'll back out my Mac change, but I need to know if I should take bold
> off
> >> of the
> >> version also.
> >>
> >> The GTK+ About box currently uses bold for the title but not for the
> >> version.
> >>
> >> I assume all three should match.  I can fix GTK+ also.
> >>
> >>
> >> http://codereview.chromium.org/347009/diff/1001/2001
> >> File chrome/browser/views/about_chrome_view.cc (right):
> >>
> >> http://codereview.chromium.org/347009/diff/1001/2001#newcode188
> >> Line 188: ResourceBundle::BaseFont).DeriveFont(0, gfx::Font::BOLD));
> >> Shouldn't we drop this too, to take boldness off of the version number?
> >>
> >> http://codereview.chromium.org/347009
> >
> >
>

[DaveMoore, 2009-10-30 17:16:15]

Took care of the bolded version too.

[Ben Goodger (Google), 2009-10-30 17:27:12]

Thanks!

On Fri, Oct 30, 2009 at 10:16 AM, <davemoore@chromium.org> wrote:

> Took care of the bolded version too.
>
>
> http://codereview.chromium.org/347009
>