Issue 3467013: Strip newline/whitespace from 'which' output when...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3467013: Strip newline/whitespace from 'which' output when... (Closed)

Created:
10 years, 3 months ago by jajones

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, evanm, M-A Ruel, zbehan

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

Description

Strip newline/whitespace from 'which' output when looking for non-standard-named depot_tools directory in git cl hooks python script. Otherwise, python ignores the path. Patch contributed by James Jones @ nvidia. BUG=chromium-os:7007 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60499

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	git-cl-upload-hook	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jajones_nvidia.com

On 2010/09/23 21:10:57, Evan Martin wrote: > LGTM Thanks Evan. Could you commit this for ...

10 years, 3 months ago (2010-09-23 21:50:35 UTC) #3

M-A Ruel

10 years, 3 months ago (2010-09-24 18:41:00 UTC) #4

On 2010/09/23 21:50:35, James Jones wrote:
> On 2010/09/23 21:10:57, Evan Martin wrote:
> > LGTM
> 
> Thanks Evan.  Could you commit this for me?

I committed.

Expand Messages | Collapse Messages