Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: git-cl-upload-hook

Issue 3467013: Strip newline/whitespace from 'which' output when... (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git-cl-upload-hook
===================================================================
--- git-cl-upload-hook (revision 60321)
+++ git-cl-upload-hook (working copy)
@@ -21,7 +21,7 @@
if not depot_tools_path:
# Grab a `which gclient', which gives first match
# `which' also uses PATH, but is not restricted to specific directory name
- path = Popen(["which", "gclient"], stdout=PIPE).communicate()[0]
+ path = Popen(["which", "gclient"], stdout=PIPE).communicate()[0].strip()
if path:
depot_tools_path = path.replace("/gclient","")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698