Issue 3462011: Manual merge of 60334 - Add a launchApp method to extension management API....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3462011: Manual merge of 60334 - Add a launchApp method to extension management API.... (Closed)

Created:
10 years, 3 months ago by asargent_no_longer_on_chrome

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/517/src/

Visibility:
Public.

Description

Manual merge of 60334 - Add a launchApp method to extension management API. This makes it possible for new tab replacement extensions to recreate the same app launch experience as the built-in NTP (pinned tabs, launch containers, etc.) Also add the extension version to data we report about extensions via the management API. BUG=56325, 55474 TEST=An extension using chrome.experimental.management.launchApp(<id>) should work to launch an app the same way that app gets launched from the built-in new tab page. Review URL: http://codereview.chromium.org/3381019 TBR=asargent@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60501

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+363 lines, -2 lines)			Patch
M	chrome/browser/extensions/extension_function_dispatcher.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_management_api.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_management_api.cc	View	3 chunks	+23 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_management_api_browsertest.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View	2 chunks	+21 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/experimental.management.html	View	3 chunks	+240 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/management/launch_app/background.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/management/launch_app/manifest.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/management/launch_app/test.js	View	1 chunk	+30 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/management/packaged_app/main.html	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/management/packaged_app/manifest.json	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/management/simple_extension/manifest.json	View	1 chunk	+4 lines, -0 lines	0 comments	Download