Add a launchApp method to extension management API....

Add a launchApp method to extension management API.

This makes it possible for new tab replacement extensions to recreate the same
app launch experience as the built-in NTP (pinned tabs, launch containers,
etc.)

Also add the extension version to data we report about extensions via
the management API.

BUG=56325, 55474
TEST=An extension using chrome.experimental.management.launchApp(<id>) should
work to launch an app the same way that app gets launched from the built-in
new tab page.




Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60334

[asargent_no_longer_on_chrome, 2010-09-23 00:11:30]

http://codereview.chromium.org/3381019/diff/1/2
File chrome/browser/extensions/extension_function_dispatcher.cc (left):

http://codereview.chromium.org/3381019/diff/1/2#oldcode277
chrome/browser/extensions/extension_function_dispatcher.cc:277:
RegisterFunction<InstallFunction>();
FYI, "InstallFunction" used to be a part of the management API, but when Rafael
moved it to the WebstorePrivate API I think he just forgot to move it down to
the section below (not that it matters for correctness, but for readability I
fixed it in this CL).

[Erik does not do reviews, 2010-09-23 00:42:16]

LGTM

Didn't you say that your change needed NTP changes as well?

Also update the description of this CL.  It's not just about pinning, but also
supporting launch container and launch modes.

http://codereview.chromium.org/3381019/diff/13001/14004
File chrome/browser/extensions/extension_management_api_browsertest.cc (right):

http://codereview.chromium.org/3381019/diff/13001/14004#newcode32
chrome/browser/extensions/extension_management_api_browsertest.cc:32:
IN_PROC_BROWSER_TEST_F(ExtensionManagementApiBrowserTest, LaunchApp) {
maybe verify the error when launching a non-app?

http://codereview.chromium.org/3381019/diff/13001/14005
File chrome/common/extensions/api/extension_api.json (right):

http://codereview.chromium.org/3381019/diff/13001/14005#newcode3943
chrome/common/extensions/api/extension_api.json:3943: "description": "The
version of this extension.",
maybe link to the version format docs

[asargent_no_longer_on_chrome, 2010-09-23 18:30:54]

[final upload responding to comments, will submit after try runs come back]


> Didn't you say that your change needed NTP changes as well?

At first glance I thought I was going to need to, but when I looked at it
closer, it turned out I didn't need to.

http://codereview.chromium.org/3381019/diff/13001/14004
File chrome/browser/extensions/extension_management_api_browsertest.cc (right):

http://codereview.chromium.org/3381019/diff/13001/14004#newcode32
chrome/browser/extensions/extension_management_api_browsertest.cc:32:
IN_PROC_BROWSER_TEST_F(ExtensionManagementApiBrowserTest, LaunchApp) {
On 2010/09/23 00:42:17, Erik Kay wrote:
> maybe verify the error when launching a non-app?

Done.

http://codereview.chromium.org/3381019/diff/13001/14005
File chrome/common/extensions/api/extension_api.json (right):

http://codereview.chromium.org/3381019/diff/13001/14005#newcode3943
chrome/common/extensions/api/extension_api.json:3943: "description": "The
version of this extension.",
On 2010/09/23 00:42:17, Erik Kay wrote:
> maybe link to the version format docs

Done.