Issue 346039: Widen a suppression for bugs 20111 and 26582, move it to "third party" section

Issue 346039: Widen a suppression for bugs 20111 and 26582, move it to "third party" section (Closed)

Created:
11 years, 1 month ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
dank

CC:
chromium-reviews_googlegroups.com, stuartmorgan, pam+watch_chromium.org, not_the_right_glider

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Widen a suppression for bugs 20111 and 26582, move it to "third party" section BUG=20111, 26582 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30837

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -13 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View	1 2 3 4	2 chunks	+8 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

Can you please suggest a shorter/wider stack for the new supperession? btw, I really think ...

11 years, 1 month ago (2009-11-03 14:17:48 UTC) #1

dkegel

(rietveld is acting up) If you're sure about that being a glibc problem, maybe we ...

11 years, 1 month ago (2009-11-03 14:26:06 UTC) #2

(rietveld is acting up)

If you're sure about that being a glibc problem, maybe we should
remove the two existing suppressions that involve this
and add one that does it generically instead of adding a new specific one.

On Tue, Nov 3, 2009 at 6:17 AM,  <timurrrr@chromium.org> wrote:
> Reviewers: dank,
>
> Message:
> Can you please suggest a shorter/wider stack for the new supperession?
>
> btw, I really think the problem is not with the caller (SafeBrowsing or
> Extensions) but rather inside libc when a thread is created with some
> specific
> options.
>
> Description:
> Revert rev 30809, add a separate suppression for bug 26582
> BUG=3D20111,26582
>
> Please review this at http://codereview.chromium.org/346039
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- tools/valgrind/memcheck/suppressions.txt =A0 =A0(revision 30809)
> +++ tools/valgrind/memcheck/suppressions.txt =A0 =A0(working copy)
> @@ -797,8 +797,7 @@
>
> =A0fun:_ZN42_GLOBAL__N__ZN14PlatformThread9CurrentIdEv12CreateThreadEjbPN=
14PlatformThread8DelegateEPm
> =A0 =A0fun:_ZN14PlatformThread6CreateEjPNS_8DelegateEPm
> =A0 =A0fun:_ZN4base6Thread16StartWithOptionsERKNS0_7OptionsE
> - =A0 ...
> - =A0 fun:*BrowserProcessImpl*
> + =A0 fun:_ZN18BrowserProcessImpl14CreateIOThreadEv
> =A0}
> =A0{
> =A0 =A0bug_20113
> @@ -1071,3 +1070,20 @@
> =A0 =A0fun:_ZN9Extension25LoadExtensionActionHelperEPK15DictionaryValuePS=
s
> =A0 =A0fun:_ZN39ExtensionTest_LoadPageActionHelper_Test8TestBodyEv
> =A0}
> +{
> + =A0 bug_26582
> + =A0 fun:calloc
> + =A0 fun:allocate_dtv
> + =A0 fun:_dl_allocate_tls
> + =A0 fun:pthread_create@@GLIBC_2.1
> +
> fun:_ZN42_GLOBAL__N__ZN14PlatformThread9CurrentIdEv12CreateThreadEjbPN14P=
latformThread8DelegateEPm
> + =A0 fun:_ZN14PlatformThread6CreateEjPNS_8DelegateEPm
> + =A0 fun:_ZN4base6Thread16StartWithOptionsERKNS0_7OptionsE
> + =A0 fun:_ZN4base6Thread5StartEv
> + =A0 fun:_ZN19SafeBrowsingService5StartEv
> + =A0 fun:_ZN19SafeBrowsingService10InitializeEv
> + =A0 fun:_ZN22ResourceDispatcherHost10InitializeEv
> + =A0 fun:_ZN18BrowserProcessImpl28CreateResourceDispatcherHostEv
> + =A0 fun:_ZN18BrowserProcessImpl24resource_dispatcher_hostEv
> + =A0 fun:_ZN17ExtensionsService4InitEv
> +}
>
>
>

Timur Iskhodzhanov

Ping On 2009/11/03 14:26:06, dkegel_google.com wrote: > (rietveld is acting up) > > If you're ...

11 years, 1 month ago (2009-11-03 18:48:27 UTC) #3

Ping
On 2009/11/03 14:26:06, dkegel_google.com wrote:
> (rietveld is acting up)
> 
> If you're sure about that being a glibc problem, maybe we should
> remove the two existing suppressions that involve this
> and add one that does it generically instead of adding a new specific one.
> 
> On Tue, Nov 3, 2009 at 6:17 AM,  <mailto:timurrrr@chromium.org> wrote:
> > Reviewers: dank,
> >
> > Message:
> > Can you please suggest a shorter/wider stack for the new supperession?
> >
> > btw, I really think the problem is not with the caller (SafeBrowsing or
> > Extensions) but rather inside libc when a thread is created with some
> > specific
> > options.
> >
> > Description:
> > Revert rev 30809, add a separate suppression for bug 26582
> > BUG=3D20111,26582
> >
> > Please review this at http://codereview.chromium.org/346039
> >
> > SVN Base: svn://svn.chromium.org/chrome/trunk/src/
> >
> > Affected files:
> > =A0M =A0 =A0 tools/valgrind/memcheck/suppressions.txt
> >
> >
> > Index: tools/valgrind/memcheck/suppressions.txt
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- tools/valgrind/memcheck/suppressions.txt =A0 =A0(revision 30809)
> > +++ tools/valgrind/memcheck/suppressions.txt =A0 =A0(working copy)
> > @@ -797,8 +797,7 @@
> >
> > =A0fun:_ZN42_GLOBAL__N__ZN14PlatformThread9CurrentIdEv12CreateThreadEjbPN=
> 14PlatformThread8DelegateEPm
> > =A0 =A0fun:_ZN14PlatformThread6CreateEjPNS_8DelegateEPm
> > =A0 =A0fun:_ZN4base6Thread16StartWithOptionsERKNS0_7OptionsE
> > - =A0 ...
> > - =A0 fun:*BrowserProcessImpl*
> > + =A0 fun:_ZN18BrowserProcessImpl14CreateIOThreadEv
> > =A0}
> > =A0{
> > =A0 =A0bug_20113
> > @@ -1071,3 +1070,20 @@
> > =A0 =A0fun:_ZN9Extension25LoadExtensionActionHelperEPK15DictionaryValuePS=
> s
> > =A0 =A0fun:_ZN39ExtensionTest_LoadPageActionHelper_Test8TestBodyEv
> > =A0}
> > +{
> > + =A0 bug_26582
> > + =A0 fun:calloc
> > + =A0 fun:allocate_dtv
> > + =A0 fun:_dl_allocate_tls
> > + =A0 fun:pthread_create@@GLIBC_2.1
> > +
> > fun:_ZN42_GLOBAL__N__ZN14PlatformThread9CurrentIdEv12CreateThreadEjbPN14P=
> latformThread8DelegateEPm
> > + =A0 fun:_ZN14PlatformThread6CreateEjPNS_8DelegateEPm
> > + =A0 fun:_ZN4base6Thread16StartWithOptionsERKNS0_7OptionsE
> > + =A0 fun:_ZN4base6Thread5StartEv
> > + =A0 fun:_ZN19SafeBrowsingService5StartEv
> > + =A0 fun:_ZN19SafeBrowsingService10InitializeEv
> > + =A0 fun:_ZN22ResourceDispatcherHost10InitializeEv
> > + =A0 fun:_ZN18BrowserProcessImpl28CreateResourceDispatcherHostEv
> > + =A0 fun:_ZN18BrowserProcessImpl24resource_dispatcher_hostEv
> > + =A0 fun:_ZN17ExtensionsService4InitEv
> > +}
> >
> >
> >

LGTM

Expand Messages | Collapse Messages