Issue 346018: 1. Show crash stacks in run_webkit_tests.py stdio...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 346018: 1. Show crash stacks in run_webkit_tests.py stdio... (Closed)

Created:
11 years, 1 month ago by ojan

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

1. Show crash stacks in run_webkit_tests.py stdio 2. Write the crash stack out to layout-test-results/LayoutTests/foo/bar-stack.txt 3. Add a link to the stack file in results.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30610

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -36 lines)			Patch
M	webkit/tools/layout_tests/layout_package/test_failures.py	View		5 chunks	+21 lines, -3 lines	0 comments	Download
M	webkit/tools/layout_tests/layout_package/test_shell_thread.py	View		13 chunks	+26 lines, -12 lines	1 comment	Download
M	webkit/tools/layout_tests/run_webkit_tests.py	View	1	1 chunk	+6 lines, -5 lines	0 comments	Download
M	webkit/tools/layout_tests/test_types/test_type_base.py	View		1 chunk	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

11 years, 1 month ago (2009-10-29 23:13:51 UTC) #2

LG

http://codereview.chromium.org/346018/diff/1001/1003
File webkit/tools/layout_tests/layout_package/test_shell_thread.py (right):

http://codereview.chromium.org/346018/diff/1001/1003#newcode211
Line 211: self._output_dir = output_dir
Nit: Maybe just use options.results_directory rather than adding an extra input
param?

Expand Messages | Collapse Messages