1. Show crash stacks in run_webkit_tests.py stdio...

webkit/tools/layout_tests/layout_package/test_failures.py

 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Classes for failures that occur during tests."""
 
+import os
+
 class FailureSort(object):
   """A repository for failure sort orders and tool to facilitate sorting."""
 
   # Each failure class should have an entry in this dictionary. Sort order 1
   # will be sorted first in the list. Failures with the same numeric sort
   # order will be sorted alphabetically by Message().
   SORT_ORDERS = {
     'FailureTextMismatch': 1,
     'FailureImageHashMismatch': 2,
     'FailureTimeout': 3,
@@ skipping 19 matching lines @@
     raise NotImplemented
 
   def ResultHtmlOutput(self, filename):
     """Returns an HTML string to be included on the results.html page."""
     raise NotImplemented
 
   def ShouldKillTestShell(self):
     """Returns True if we should kill the test shell before the next test."""
     return False
 
+  def RelativeOutputFilename(self, filename, modifier):
+    """Returns a relative filename inside the output dir that contains
+    modifier.
+
+    For example, if filename is fast\dom\foo.html and modifier is
+    "-expected.txt", the return value is fast\dom\foo-expected.txt
+
+    Args:
+      filename: relative filename to test file
+      modifier: a string to replace the extension of filename with
+
+    Return:
+      The relative windows path to the output filename
+    """
+    return os.path.splitext(filename)[0] + modifier
 
 class FailureWithType(TestFailure):
   """Base class that produces standard HTML output based on the test type.
 
   Subclasses may commonly choose to override the ResultHtmlOutput, but still
   use the standard OutputLinks.
   """
   def __init__(self, test_type):
     TestFailure.__init__(self)
+    # TODO(ojan): This class no longer needs to know the test_type.
     self._test_type = test_type
 
   # Filename suffixes used by ResultHtmlOutput.
   OUT_FILENAMES = []
 
   def OutputLinks(self, filename, out_names):
     """Returns a string holding all applicable output file links.
 
     Args:
       filename: the test filename, used to construct the result file names
       out_names: list of filename suffixes for the files. If three or more
           suffixes are in the list, they should be [actual, expected, diff,
           wdiff].
           Two suffixes should be [actual, expected], and a single item is the
           [actual] filename suffix.  If out_names is empty, returns the empty
           string.
     """
     links = ['']
-    uris = [self._test_type.RelativeOutputFilename(filename, fn)
-            for fn in out_names]
+    uris = [self.RelativeOutputFilename(filename, fn) for fn in out_names]
     if len(uris) > 1:
       links.append("<a href='%s'>expected</a>" % uris[1])
     if len(uris) > 0:
       links.append("<a href='%s'>actual</a>" % uris[0])
     if len(uris) > 2:
       links.append("<a href='%s'>diff</a>" % uris[2])
     if len(uris) > 3:
       links.append("<a href='%s'>wdiff</a>" % uris[3])
     return ' '.join(links)
 
@@ skipping 16 matching lines @@
 
 
 class FailureCrash(TestFailure):
   """Test shell crashed."""
   @staticmethod
   def Message():
     return "Test shell crashed"
 
   def ResultHtmlOutput(self, filename):
     # TODO(tc): create a link to the minidump file
-    return "<strong>%s</strong>" % self.Message()
+    stack = self.RelativeOutputFilename(filename, "-stack.txt")
+    return "<strong>%s</strong> <a href=%s>stack</a>" % (self.Message(), stack)
 
   def ShouldKillTestShell(self):
     return True
 
 
 class FailureMissingResult(FailureWithType):
   """Expected result was missing."""
   OUT_FILENAMES = ["-actual.txt"]
 
   @staticmethod
@@ skipping 72 matching lines @@
   # Chrome doesn't know to display a .checksum file as text, so don't bother
   # putting in a link to the actual result.
   OUT_FILENAMES = []
 
   @staticmethod
   def Message():
     return "Images match, expected image hash incorrect. "
 
   def ResultHtmlOutput(self, filename):
     return "<strong>%s</strong>" % self.Message()