DescriptionMerge 59579 - The recent change for setting LD_LIBRARY_PATH doesn't actually work, as the
script is executed by /bin/sh. On many systems, /bin/sh does not have support
for "[[". We could either switch to a different shell (e.g. /bin/bash), we
could switch to using "[" instead, or we could avoid the entire problem by
using "${:+}" variable expansion.
I tested that the latter does the right thing with /bin/bash, /bin/ash,
/bin/dash, /bin/zsh, /bin/sh (the latter being a symbolic link to /bin/dash).
So, I think we are on the safe side.
BUG=54132
TEST=Start Chrome and notice that there no longer is an error message about "[[" being unavailable
Review URL: http://codereview.chromium.org/3412004
TBR=markus@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59599
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|