Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 3412004: The recent change for setting LD_LIBRARY_PATH doesn't actually work, as the... (Closed)

Created:
10 years, 3 months ago by Markus (顧孟勤)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

The recent change for setting LD_LIBRARY_PATH doesn't actually work, as the script is executed by /bin/sh. On many systems, /bin/sh does not have support for "[[". We could either switch to a different shell (e.g. /bin/bash), we could switch to using "[" instead, or we could avoid the entire problem by using "${:+}" variable expansion. I tested that the latter does the right thing with /bin/bash, /bin/ash, /bin/dash, /bin/zsh, /bin/sh (the latter being a symbolic link to /bin/dash). So, I think we are on the safe side. BUG=54132 TEST=Start Chrome and notice that there no longer is an error message about "[[" being unavailable Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/tools/build/linux/chrome-wrapper View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Markus (顧孟勤)
10 years, 3 months ago (2010-09-15 22:56:56 UTC) #1
Michael Moss
10 years, 3 months ago (2010-09-15 23:29:50 UTC) #2
Ugh, yes, this is much cleaner. LGTM.

Powered by Google App Engine
This is Rietveld 408576698