Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: net/http/http_response_headers.h

Issue 3453021: Immediately reject empty cookie headers. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: updates Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_response_headers.h
diff --git a/net/http/http_response_headers.h b/net/http/http_response_headers.h
index 8e011f8d9304bc45e2f7aefe0ea6751887623fab..aacd35a5ecdfa575834b62b38ff63ac7cbfc3c13 100644
--- a/net/http/http_response_headers.h
+++ b/net/http/http_response_headers.h
@@ -138,9 +138,10 @@ class HttpResponseHeaders
// method returns the un-coalesced response header lines, so if a response
// header appears on multiple lines, then it will appear multiple times in
// this enumeration (in the order the header lines were received from the
- // server). Initialize a 'void*' variable to NULL and pass it by address to
- // EnumerateHeaderLines. Call EnumerateHeaderLines repeatedly until it
- // returns false. The out-params 'name' and 'value' are set upon success.
+ // server). Also, a given header might have an empty value. Initialize a
+ // 'void*' variable to NULL and pass it by address to EnumerateHeaderLines.
+ // Call EnumerateHeaderLines repeatedly until it returns false. The
+ // out-params 'name' and 'value' are set upon success.
bool EnumerateHeaderLines(void** iter,
std::string* name,
std::string* value) const;
@@ -149,7 +150,8 @@ class HttpResponseHeaders
// in the first header, then you can pass NULL for the 'iter' parameter.
// Otherwise, to iterate across all values for the specified header,
// initialize a 'void*' variable to NULL and pass it by address to
- // EnumerateHeader. Call EnumerateHeader repeatedly until it returns false.
+ // EnumerateHeader. Note that a header might have an empty value. Call
+ // EnumerateHeader repeatedly until it returns false.
bool EnumerateHeader(void** iter,
const std::string& name,
std::string* value) const;
« no previous file with comments | « no previous file | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698