net/url_request/url_request_http_job.cc - Issue 3453021: Immediately reject empty cookie headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_http_job.cc

Issue 3453021: Immediately reject empty cookie headers. (Closed) Base URL: git://codf21.jail/chromium.git

Patch Set: updates Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_http_job.cc

diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc

index 11df1d059f656912f64c22d73140b6b47edb18da..a3e88ab52b8b880a86ca6b2a923692a70d86c334 100644

--- a/net/url_request/url_request_http_job.cc

+++ b/net/url_request/url_request_http_job.cc

@@ -793,8 +793,10 @@ void URLRequestHttpJob::FetchResponseCookies(

std::string value;

void* iter = NULL;

- while (response_info->headers->EnumerateHeader(&iter, name, &value))

- cookies->push_back(value);

+ while (response_info->headers->EnumerateHeader(&iter, name, &value)) {

+ if (!value.empty())

+ cookies->push_back(value);

+ }

}

class HTTPSProberDelegate : public net::HTTPSProberDelegate {

« no previous file with comments | « net/http/http_response_headers.h ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »