DescriptionMerge 67641 - 2010-09-16 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
Fix incorrect usage of dissolveDragImageToFraction().
https://bugs.webkit.org/show_bug.cgi?id=45835
createDragImageForSelection() was ignoring the return value of
dissolveDragImageToFraction(). This didn't happen to crash on most
platforms, since most implementations simply modified the image that was
passed in. However, Chromium Mac's implementation actually creates a new
image and returns that instead. This caused us to crash when copying the
image from the renderer to the browser process, since the memory had
already been freed.
* manual-tests/selection-drag-crash.html: Added.
* platform/DragImage.cpp:
(WebCore::createDragImageForSelection):
TBR=tony@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67644
Patch Set 1 #
Messages
Total messages: 1 (0 generated)
|