Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 3452007: Merge 67641 - 2010-09-16 Daniel Cheng <dcheng@chromium.org>... (Closed)

Created:
10 years, 3 months ago by levin
Modified:
9 years, 7 months ago
Reviewers:
levin
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/
Visibility:
Public.

Description

Merge 67641 - 2010-09-16 Daniel Cheng <dcheng@chromium.org>; Reviewed by Tony Chang. Fix incorrect usage of dissolveDragImageToFraction(). https://bugs.webkit.org/show_bug.cgi?id=45835 createDragImageForSelection() was ignoring the return value of dissolveDragImageToFraction(). This didn't happen to crash on most platforms, since most implementations simply modified the image that was passed in. However, Chromium Mac's implementation actually creates a new image and returns that instead. This caused us to crash when copying the image from the renderer to the browser process, since the memory had already been freed. * manual-tests/selection-drag-crash.html: Added. * platform/DragImage.cpp: (WebCore::createDragImageForSelection): TBR=tony@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A + WebCore/manual-tests/selection-drag-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M WebCore/platform/DragImage.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
levin
10 years, 3 months ago (2010-09-16 18:55:46 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698