WebCore/manual-tests/selection-drag-crash.html - Issue 3452007: Merge 67641 - 2010-09-16 Daniel Cheng <dcheng@chromium.org>...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: WebCore/manual-tests/selection-drag-crash.html

Issue 3452007: Merge 67641 - 2010-09-16 Daniel Cheng <dcheng@chromium.org>... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/517/

Patch Set: Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

4 function selectText() {	4 function selectText() {

5 window.getSelection().selectAllChildren(document.body);	5 window.getSelection().selectAllChildren(document.body);

6 }	6 }

7 </script>	7 </script>

8 </head>	8 </head>

9 <body onload="selectText()">	9 <body onload="selectText()">

10 <p>	10 <p>

11 Drag the selected text. It shouldn't crash, though it used to on Chromium Mac si nce createDragImageForSelection() didn't properly use the return value from diss olveDragImageToFraction(), which resulted in a race condition for the drag image 's refcount. This issue can't be tested in an automated manner, due to the fact that the race condition is hard to trigger deterministically and that test_shell /DRT simply don't use the (potentially invalid) image parameter.	11 Drag the selected text. It shouldn't crash, though it used to on Chromium Mac si nce createDragImageForSelection() didn't properly use the return value from diss olveDragImageToFraction(), which resulted in a race condition for the drag image 's refcount. This issue can't be tested in an automated manner, due to the fact that the race condition is hard to trigger deterministically and that test_shell /DRT simply don't use the (potentially invalid) image parameter.

12 </p>	12 </p>

13 </body>	13 </body>

14 </html>	14 </html>

OLD	NEW

« no previous file with comments | « no previous file | WebCore/platform/DragImage.cpp » ('j') | no next file with comments »