Bookmark context menu "Edit" starts with current name, not "New Folder"....

Bookmark context menu "Edit" starts with current name, not "New Folder".
"Add Folder..." from either buttons or bar happier (always adds, doesn't edit).
"Add Folder..." now allows you to rename new folders the default name ("New Folder").


BUG=http://crbug.com/26364, http://crbug.com/26407

TEST=Over a bookmark button for a 'mark or folder, context menu --> Edit.
Make sure initial name is current name, not "New Folder".
Over button for 'mark, for folder, or bar itself: context menu --> Add Folder.
Make sure initial name is "New Folder", and that it creates a folder (not a rename).
Make sure you are allowed to create a folder named "New Folder".


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30866

[mrossetti, 2009-11-03 16:11:28]

LGTM

http://codereview.chromium.org/345045/diff/1/4
File chrome/browser/cocoa/bookmark_name_folder_controller.h (right):

http://codereview.chromium.org/345045/diff/1/4#newcode15
Line 15: // renaming an existing folder.  Accessible from a context menu on a
s/renaming/rename/

[pink (ping after 24hrs), 2009-11-03 16:49:05]

lgtm

http://codereview.chromium.org/345045/diff/1/3
File chrome/browser/cocoa/bookmark_bar_controller.mm (right):

http://codereview.chromium.org/345045/diff/1/3#newcode487
Line 487: [[BookmarkNameFolderController alloc]
continuation lines indent additional 4 spaces

http://codereview.chromium.org/345045/diff/1/5
File chrome/browser/cocoa/bookmark_name_folder_controller.mm (right):

http://codereview.chromium.org/345045/diff/1/5#newcode28
Line 28: l10n_util::GetString(IDS_BOOMARK_EDITOR_NEW_FOLDER_NAME);
GetNSStringWithFixup?

[John Grabowski, 2009-11-03 20:18:41]

Final diffs up; thx guys.

http://codereview.chromium.org/345045/diff/1/3
File chrome/browser/cocoa/bookmark_bar_controller.mm (right):

http://codereview.chromium.org/345045/diff/1/3#newcode487
Line 487: [[BookmarkNameFolderController alloc]
On 2009/11/03 16:49:05, pink wrote:
> continuation lines indent additional 4 spaces

M-x need-to-fix-emacs <RET> ARGH! <RET>

http://codereview.chromium.org/345045/diff/1/4
File chrome/browser/cocoa/bookmark_name_folder_controller.h (right):

http://codereview.chromium.org/345045/diff/1/4#newcode15
Line 15: // renaming an existing folder.  Accessible from a context menu on a
On 2009/11/03 16:11:28, mrossetti wrote:
> s/renaming/rename/
sedded

http://codereview.chromium.org/345045/diff/1/5
File chrome/browser/cocoa/bookmark_name_folder_controller.mm (right):

http://codereview.chromium.org/345045/diff/1/5#newcode28
Line 28: l10n_util::GetString(IDS_BOOMARK_EDITOR_NEW_FOLDER_NAME);
On 2009/11/03 16:49:05, pink wrote:
> GetNSStringWithFixup?

done