Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/cocoa/bookmark_bar_controller.mm

Issue 345045: Bookmark context menu "Edit" starts with current name, not "New Folder".... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/bookmark_bar_controller.mm
===================================================================
--- chrome/browser/cocoa/bookmark_bar_controller.mm (revision 30684)
+++ chrome/browser/cocoa/bookmark_bar_controller.mm (working copy)
@@ -482,11 +482,13 @@
- (IBAction)editBookmark:(id)sender {
BookmarkNode* node = [self nodeFromMenuItem:sender];
- // TODO(jrg): on windows, folder "buttons" use the bar's context
- // menu (but with extra items enabled, like Rename). For now we do
- // a cheat and redirect so we have the functionality available.
if (node->is_folder()) {
- [self addOrRenameFolder:sender];
+ BookmarkNameFolderController* controller =
+ [[BookmarkNameFolderController alloc]
+ initWithParentWindow:[[self view] window]
+ profile:browser_->profile()
+ node:node];
+ [controller runAsModalSheet];
return;
}
@@ -557,19 +559,13 @@
}
// Might be from the context menu over the bar OR over a button.
-- (IBAction)addOrRenameFolder:(id)sender {
- // node is NULL if we were invoked from the bar, and that's fine.
- BookmarkNode* node = [self nodeFromMenuItem:sender];
+- (IBAction)addFolder:(id)sender {
BookmarkNameFolderController* controller =
[[BookmarkNameFolderController alloc]
initWithParentWindow:[[self view] window]
profile:browser_->profile()
- node:node];
+ node:NULL];
[controller runAsModalSheet];
-
- // runAsModalSheet will run the window as a sheet. The
- // BookmarkNameFolderController will release itself when the sheet
- // ends.
}
- (BookmarkBarView*)buttonView {
« no previous file with comments | « chrome/browser/cocoa/bookmark_bar_controller.h ('k') | chrome/browser/cocoa/bookmark_name_folder_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698