Issue 345022: GTK Improve look of about dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345022: GTK Improve look of about dialog. (Closed)

Created:
11 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher, Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -38 lines)			Patch
	M	chrome/browser/gtk/about_chrome_dialog.cc	View	1	10 chunks	+63 lines, -38 lines	0 comments	Download

Total messages: 6 (0 generated)

Evan Stade

also see the wontfix'd crbug.com/25166 for an explanation of why the text looks a little ...

11 years, 1 month ago (2009-10-29 20:38:48 UTC) #1

Evan Stade

eh, one second. Should probably reduce the empty vertical space above the close button.

11 years, 1 month ago (2009-10-29 20:40:03 UTC) #2

Ben Goodger (Google)

Looks like you're headed in the right direction... LGTM aesthetically. On Thu, Oct 29, 2009 ...

11 years, 1 month ago (2009-10-29 20:41:52 UTC) #3

Ben Goodger (Google)

11 years, 1 month ago (2009-10-29 20:58:55 UTC) #6

LGTM.

On Thu, Oct 29, 2009 at 1:57 PM, <erg@chromium.org> wrote:

> Hooray! Markup crud is gone! LGTM.
>
>
> http://codereview.chromium.org/345022
>