Change update threshold in CookieMonster for testing from 1s to 20ms.

Change update threshold in CookieMonster for testing from 1s to 20ms to speedup test.

BUG=24687
TEST=unit tests still pass


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30385

[Roger Tawa OOO till Jul 10th, 2009-10-28 19:11:03]

Thanks for looking into this.  How much does this change affect the running time
of the test?  When I first looked at the problem, it seemed the test was not
firing an event when done, causing it to wait for the duration of the timeout of
the test, which is 10 seconds.

[vandebo (ex-Chrome), 2009-10-28 19:37:30]

On 2009/10/28 19:11:03, Roger Tawa wrote:
> Thanks for looking into this.  How much does this change affect the running
time
> of the test?  When I first looked at the problem, it seemed the test was not
> firing an event when done, causing it to wait for the duration of the timeout
of
> the test, which is 10 seconds.

When I run the test under linux now, it takes around half a second.  Before the
change, it took about 12.5 seconds.  Maybe you are thinking of a different test?

[Roger Tawa OOO till Jul 10th, 2009-10-28 19:44:56]

The bug id in the comments of this CL mentions BrowserEventExtensionTest, but
this CL only affects the cookie monster unittest.  I'm not sure what the
relationship is between the two.   Can you explain please?  Thanks.

[vandebo (ex-Chrome), 2009-10-28 19:53:27]

Yea, I'm working on the assumption that there was a copy/paste mistake - See the
subject of the issue and compare with issue 26689 (2 away).  I think this issue
is supposed to be about  CookieMonsterTest.TestTotalGarbageCollection.  Are you
not a good reviewer for that?

[(NOT FOR CODE REVIEWS), 2009-10-28 20:09:31]

OK, makes lots of sense.  I am not the right reviewer for this change.

Thanks,
Roger

-



On Wed, Oct 28, 2009 at 12:53,  <vandebo@chromium.org> wrote:
> Yea, I'm working on the assumption that there was a copy/paste mistake - =
See
> the
> subject of the issue and compare with issue 26689 (2 away). =A0I think th=
is
> issue
> is supposed to be about =A0CookieMonsterTest.TestTotalGarbageCollection. =
=A0Are
> you
> not a good reviewer for that?
>
>
> http://codereview.chromium.org/345012
>

[Paweł Hajdan Jr., 2009-10-28 20:38:09]

I think pkasting is the right reviewer.

[Peter Kasting, 2009-10-28 20:43:42]

LGTM

http://codereview.chromium.org/345012/diff/1/2
File net/base/cookie_monster_unittest.cc (right):

http://codereview.chromium.org/345012/diff/1/2#newcode836
Line 836: PlatformThread::Sleep(kLastAccessThresholdMilliseconds + 10);
For safety due to Windows' low timer resolution, I'd make this "+ 20" rather
than "+ 10".  (2 places)